Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #include "awint.hpp" #3937

Closed
AlexGuteniev opened this issue Aug 8, 2023 · 2 comments · Fixed by #4015
Closed

Cleanup #include "awint.hpp" #3937

AlexGuteniev opened this issue Aug 8, 2023 · 2 comments · Fixed by #4015
Labels
enhancement Something can be improved fixed Something works now, yay!

Comments

@AlexGuteniev
Copy link
Contributor

AlexGuteniev commented Aug 8, 2023 •
edited by CaseyCarter
Loading

There are fewer places that actually needs #include "awint.hpp" than the places where it is included.

Some may need other includes that included by "awint.hpp" instead, for others this include may be completely superfluous.

After #3936, we shouldn't need #include "awint.hpp" in winapisupp.cpp itself.
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Aug 8, 2023
@ayushgupta9906
Copy link

Please assign this issue to me.

@AlexGuteniev
Copy link
Contributor Author

Please assign this issue to me.

There's no assignment to contributors.
Feel free to create a PR, whoever makes it, takes it.

@grcm10 grcm10 mentioned this issue Sep 8, 2023
Merged
@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Something can be improved fixed Something works now, yay!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary #include "awint.hpp" grcm10/STL
4 participants
@CaseyCarter @AlexGuteniev @StephanTLavavej @ayushgupta9906