Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attributes: consider supporting more _ATTRIBUTE macros #3834

Closed
achabense opened this issue Jun 26, 2023 · 1 comment
Closed

attributes: consider supporting more _ATTRIBUTE macros #3834

achabense opened this issue Jun 26, 2023 · 1 comment
Labels
enhancement Something can be improved

Comments

@achabense
Copy link
Contributor

achabense commented Jun 26, 2023

Currently we have _NODISCARD and _FALLTHROUGH, which will expand to [[attribute]] if supported, or nothing otherwise.

I think it will be very helpful to support more _ATTRIBUTE macros for standard attributes. For example, in this pr, we can make the code much cleaner if we have _LIKELY and _UNLIKELY.

@achabense achabense changed the title attributes: Consider implementing _LIKELY and _UNLIKELY attributes: consider supporting more _ATTRIBUTE macros for standard attributes Jun 27, 2023
@achabense achabense changed the title attributes: consider supporting more _ATTRIBUTE macros for standard attributes attributes: consider supporting more _ATTRIBUTE macros Jun 27, 2023
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Jul 5, 2023
@achabense
Copy link
Contributor Author

I think this is useless as a separate issue; we can introduce these macros whenever there is real need for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

No branches or pull requests

2 participants