-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P1328R1 constexpr
type_info::operator==()
#1972
Comments
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I have created an internal PR to update |
Merged MSVC-PR-392482 for 17.3 Preview 1. |
Is the vcruntime open source delay because of the previously mentioned performance stuff? (i.e. the lack of a way to make sure 3rd party submissions aren't hurting perf) |
Yes, that is the case. Until we have some kind of benchmarking in place to defend against critical perf regression, we're not comfortable open-sourcing VCRuntime. (Despite that the vast majority of VCRuntime changes that come from the STL don't touch perf-critical code.) |
Obvious question is why it can't be opened up but (as with patches that break ABI) patches to perf critical code not accepted for merge until the infrastructure is in place to detect regressions. |
That's a good question which I wasn't motivated enough to get an answer to. @MahmoudGSaleh and @mnatsuhara were involved more directly in the cross-team opensourcing discussions, maybe Mahmoud could comment? |
17.3 Preview 1 didn't contain an MSVC toolset update (due to factors outside of our control) - we are actually waiting for 17.3 Preview 2 here. |
P1328R1
constexpr
type_info::operator==()
Feature-test macro:
The text was updated successfully, but these errors were encountered: