Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<optional> <variant> etc. #pragma message for old standard mode should have STL#### prefix #155

Closed
BillyONeal opened this issue Oct 2, 2019 · 1 comment · Fixed by #2061
Closed

<optional> <variant> etc. #pragma message for old standard mode should have STL#### prefix #155

BillyONeal opened this issue Oct 2, 2019 · 1 comment · Fixed by #2061
Labels
enhancement Something can be improved fixed Something works now, yay!

Comments

@BillyONeal
Copy link
Member

BillyONeal commented Oct 2, 2019 •
edited by StephanTLavavej
Loading

The Visual Studio IDE team would like to better surface cases when users try to use new language features in older language modes, as the IDE currently can't display the pragma messages we use, like:

STL/stl/inc/optional

Line 641 in b72c0a6

#pragma message("class template optional is only available with C++17 or later.")

They requested that we change that message to be of the form STLNNNN (where N are digits) just like the rest of the library-generated diagnostics.
@BillyONeal BillyONeal added the enhancement Something can be improved label Oct 2, 2019
@BillyONeal BillyONeal self-assigned this Oct 2, 2019
@StephanTLavavej
Copy link
Member

Related: #209 "STL: Consider cleaning up and numbering static_assert messages".

@BillyONeal BillyONeal removed their assignment Oct 28, 2019
@fsb4000 fsb4000 mentioned this issue Jul 15, 2021
Merged
@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Something can be improved fixed Something works now, yay!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add STL4038 prefix to "requires C++NN or later" messages fsb4000/STL
2 participants
@BillyONeal @StephanTLavavej