<random>: Implement LWG-3519 (#2208)

Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Casey Carter <[email protected]>

Author: 3 people

Diff for: stl/inc/iterator

@@ -1477,10 +1477,7 @@ public:
         return _Tmp;
     }
 
-#ifndef __CUDACC__ // TRANSITION, VSO-568006
-    _NODISCARD
-#endif // TRANSITION, VSO-568006
-    friend constexpr checked_array_iterator operator+(
+    _NODISCARD_FRIEND constexpr checked_array_iterator operator+(
         const difference_type _Off, const checked_array_iterator<_Ptr>& _Next) noexcept {
         return _Next + _Off;
     }
@@ -1656,10 +1653,7 @@ public:
         return _Tmp;
     }
 
-#ifndef __CUDACC__ // TRANSITION, VSO-568006
-    _NODISCARD
-#endif // TRANSITION, VSO-568006
-    friend constexpr unchecked_array_iterator operator+(
+    _NODISCARD_FRIEND constexpr unchecked_array_iterator operator+(
         const difference_type _Off, const unchecked_array_iterator& _Next) noexcept {
         return _Next + _Off;
     }