From fbd5016350a4aab22e8b2b0db7c15940c6c2f4c7 Mon Sep 17 00:00:00 2001 From: "Jens H. Nielsen" Date: Wed, 8 Nov 2023 15:47:49 +0100 Subject: [PATCH 1/3] fix call to incorrect parameter in Agilent8257D driver --- src/qcodes/instrument_drivers/agilent/Agilent_E8257D.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qcodes/instrument_drivers/agilent/Agilent_E8257D.py b/src/qcodes/instrument_drivers/agilent/Agilent_E8257D.py index fed23418634..dd8146956a4 100644 --- a/src/qcodes/instrument_drivers/agilent/Agilent_E8257D.py +++ b/src/qcodes/instrument_drivers/agilent/Agilent_E8257D.py @@ -132,10 +132,10 @@ def __init__( self.connect_message() def on(self) -> None: - self.set("status", "on") + self.output_enabled.set("on") def off(self) -> None: - self.set("status", "off") + self.output_enabled.set("off") # functions to convert between rad and deg @staticmethod From 9f0e81ed389a72c7dfd25f1cde1b8bc74c40d63f Mon Sep 17 00:00:00 2001 From: "Jens H. Nielsen" Date: Wed, 8 Nov 2023 15:51:14 +0100 Subject: [PATCH 2/3] Add changelog for 5496 --- docs/changes/newsfragments/5496.improved | 1 + 1 file changed, 1 insertion(+) create mode 100644 docs/changes/newsfragments/5496.improved diff --git a/docs/changes/newsfragments/5496.improved b/docs/changes/newsfragments/5496.improved new file mode 100644 index 00000000000..d4b510ee8d6 --- /dev/null +++ b/docs/changes/newsfragments/5496.improved @@ -0,0 +1 @@ +Fixed a bug in the Agilent 8257D where on and off would call a non existing parameter. The methods have been updated to call output_enable. From 1e2ea28d91558d1cc92985962d806d2a2bb9bad9 Mon Sep 17 00:00:00 2001 From: Jens Hedegaard Nielsen Date: Thu, 9 Nov 2023 10:45:20 +0100 Subject: [PATCH 3/3] improve wording Co-authored-by: Mikhail Astafev --- docs/changes/newsfragments/5496.improved | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/changes/newsfragments/5496.improved b/docs/changes/newsfragments/5496.improved index d4b510ee8d6..d1d13616f5c 100644 --- a/docs/changes/newsfragments/5496.improved +++ b/docs/changes/newsfragments/5496.improved @@ -1 +1 @@ -Fixed a bug in the Agilent 8257D where on and off would call a non existing parameter. The methods have been updated to call output_enable. +Fixed a bug in the Agilent 8257D where on and off would call a non existing parameter. The methods have been updated to call ``output_enabled``.