Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify default values of arguments for all snapshot_base and snapshot methods in qcodes repo #4808

Open
astafan8 opened this issue Nov 16, 2022 · 0 comments

Comments

@astafan8
Copy link
Contributor

To promote "the same" behaviour unless needed explicitly.

For example, the ZIHDAWG8 driver - does anyone know why is this override needed? how is this instrument special to all the other instruments? (this code snippet is not from the latest main branch, but similar ones can be found in the repo)
https://github.com/QCoDeS/Qcodes/blob/295ad9043ba52d61432b4e73ab1a39714572bb0c/qcodes/instrument_drivers/ZI/ZIHDAWG8.py#L79-L81

Also, look at Parameter/Instrument/Channel/Station if there's consistency.

This is created as a substitute for #1830.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant