From 454e53ff7d9d2b2d874378762521fd61610f90a0 Mon Sep 17 00:00:00 2001 From: "Jens H. Nielsen" Date: Thu, 2 Jun 2022 14:52:51 +0200 Subject: [PATCH] Visa improvements to snapshot Get value of terminator from visa_handle.read_termination Its not clear if this should be read or write and really we should log both so extend snapshot with explicit read and write terminators --- qcodes/instrument/visa.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/qcodes/instrument/visa.py b/qcodes/instrument/visa.py index 92a78b01df8..e14e2b57eb8 100644 --- a/qcodes/instrument/visa.py +++ b/qcodes/instrument/visa.py @@ -253,8 +253,10 @@ def snapshot_base(self, update: Optional[bool] = True, snap = super().snapshot_base(update=update, params_to_skip_update=params_to_skip_update) - snap['address'] = self._address - snap['terminator'] = self._terminator - snap['timeout'] = self.timeout.get() + snap["address"] = self._address + snap["terminator"] = self.visa_handle.read_termination + snap["read_terminator"] = self.visa_handle.read_termination + snap["write_terminator"] = self.visa_handle.write_termination + snap["timeout"] = self.timeout.get() return snap