Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Icon For Window Walking #3320

Closed
BenConstable9 opened this issue May 20, 2020 · 14 comments
Closed

Show Icon For Window Walking #3320

BenConstable9 opened this issue May 20, 2020 · 14 comments
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Issue-Feature A planned feature addition to a product Product-PowerToys Run Improved app launch PT Run (Win+R) Window
Milestone

Comments

@BenConstable9
Copy link
Contributor

Summary of the new feature/enhancement

When using power toys run, the open windows should have their icon shown instead of the same icon for all open windows. See below where Edge has icon for an application which is not running but no icon for the open one.

image

@saahmedm saahmedm added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label May 20, 2020
@crutkas
Copy link
Member

crutkas commented May 20, 2020

@betsegaw what are your thoughts here? I think we need to make it very clear it is a running process.

thumbnail? I know you did a lot more thinking about this.

@crutkas crutkas added the Idea-Enhancement New feature or request on an existing product label May 20, 2020
@BenConstable9
Copy link
Contributor Author

BenConstable9 commented May 20, 2020

@betsegaw what are your thoughts here? I think we need to make it very clear it is a running process.

thumbnail? I know you did a lot more thinking about this.

Realise you want to keep the running applications separate from the others. Maybe split the dropdown into segments like Spotlight search with a section for running applications (with their icons), one for applications on the system and files?

@crutkas
Copy link
Member

crutkas commented May 20, 2020

@BenConstable9 this is actually the type of feedback we are heavily interested in. single master list versus plugins each having their own

@betsegaw
Copy link
Contributor

@crutkas - thumbnails would be one choice though I wonder how much info a thumbnail of that size would show?

One other option I have thought of is using the icon of the running app with a bold outline and some sort of glow (think Instagram profiles vs one's with stories) to provide distinction between running windows vs. launch windows.

I kind of like the above option since it unifies the experience of both launch and switch by highlighting which ones would be launched and which ones would be switched to at a glance.

@betsegaw
Copy link
Contributor

betsegaw commented May 20, 2020

To make it clear, here is the profile distinction I see in Instagram,

image

vs.

image

Had to red out the profile pic on the second one since it is not my profile but you get the difference. The outline (with some slight glow) would make it easy to distinguish which one is which + we would be able to use the apps own icon.

@crutkas
Copy link
Member

crutkas commented May 20, 2020

I like the glow idea! Maybe we do an overlay of "Running" like Edge does for dev branch?

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented May 23, 2020

What about using buttons on icons? Like OneDrive and Dropbox create buttons on icons. We could create a button for "app" , "file", "web" and who knows what more.

@BenConstable9
Copy link
Contributor Author

I like the glow idea! Maybe we do an overlay of "Running" like Edge does for dev branch?

@crutkas Once it is decided what is happening, can I take it to do as a good first issue if I can figure out what to change?

@BenConstable9
Copy link
Contributor Author

I've tried to make a change to fix this issue but come into an issue. With the object result which is passed back to the launcher, for UWP apps, there is a field called Icon which will accept an ImageSource as the parameter but for the WindowWalker result, if I change IcoPath to Icon and try and return a ImageSource rather than a Image URI, I get a compilation error.

Am I missing something obvious as both result objects use the Wox Result class?

For UWP
var result = new Result { SubTitle = "Packaged application", Icon = Logo, Score = score, ContextData = this, Action = e => { Launch(api); return true; } };

For WindowWalker

return _results.Select(x => new Result() { Title = x.Result.Title, IcoPath = IcoPath, SubTitle = "Running: " + x.Result.ProcessName, Action = c => { x.Result.SwitchToWindow(); return true; } } ).ToList();

@MartinLichtblau
Copy link

MartinLichtblau commented May 29, 2020

Since icons itself are diverse and colorful, I doubt that a simple transformation is consistently leading to the desired outcome, that is to tell the different types of entries apart. And what about other types of entries, that might come up in the future, like recently closed items (history) or tabs.

My feeling is that dividers are better, so that all entries of the same type are aggregated together. Furthermore when I search I know whether I look for an open app or want to launch a new one, so a prefix symbol should work too, e.g. one whitespace to launch, two for history, ...
Overall, users request to see running apps first, like in #3169 . So, show runnings apps on top, thereby having an implicit divider, and this issue here might just become obsolete 😉

What certainly shouldn't happen is that all running apps receive the same icon like seen here.

If you stick with icons, I suggest using sth. like the Windows loading circle to intuitively indicate the running property.

@jyuwono jyuwono added this to the v1.0 Release milestone Jun 3, 2020
@saahmedm saahmedm modified the milestones: v1.0 Release, InVEST-2009 Aug 14, 2020
@saahmedm saahmedm added the Issue-Feature A planned feature addition to a product label Aug 14, 2020
@saahmedm saahmedm added the Help Wanted We encourage anyone to jump in on these and submit a PR. label Sep 1, 2020
@saahmedm saahmedm removed this from the InVEST-2009 milestone Sep 1, 2020
@crutkas
Copy link
Member

crutkas commented Sep 1, 2020

we did update this, not perfect but
image

@crutkas
Copy link
Member

crutkas commented Oct 13, 2020

viewing this as done for now

@crutkas crutkas closed this as completed Oct 13, 2020
@github-project-automation github-project-automation bot moved this to ⚠️Needs Walkthrough in 3. Help Wanted Mar 22, 2024
@andrew-shc
Copy link

Is there an option to disable this? I'm using this as an alt-tab replacement and would be awesome if the app icon can be shown again on running processes.

@roberto-gigli
Copy link

Can an option to display icons for windows walking be added? It is a bit difficult to recognize what apps are open at a glance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Issue-Feature A planned feature addition to a product Product-PowerToys Run Improved app launch PT Run (Win+R) Window
Projects
Status: ⚠️Needs Walkthrough
Development

No branches or pull requests

9 participants