CmdPal: Fix opening SUI pages in other languages (#38153)

zadjii-msft · web-flow · commit 2cb63f5fbefc · 2025-03-26T15:23:59.000+08:00
What we were doing only worked in English. The `.ToString` would get
you the text of the nav item, not the `Tag`

`InvokedItemContainer` gets you the `NavigationViewItem`.
diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI/Settings/SettingsWindow.xaml.cs b/src/modules/cmdpal/Microsoft.CmdPal.UI/Settings/SettingsWindow.xaml.cs
@@ -42,12 +42,8 @@ private void NavView_Loaded(object sender, RoutedEventArgs e)
 
     private void NavView_ItemInvoked(NavigationView sender, NavigationViewItemInvokedEventArgs args)
     {
-        var selectedItem = args.InvokedItem;
-
-        if (selectedItem is not null)
-        {
-            Navigate(selectedItem.ToString()!);
-        }
+        var selectedItem = args.InvokedItemContainer;
+        Navigate((selectedItem.Tag as string)!);
     }
 
     private void Navigate(string page)

Original file line number	Diff line number	Diff line change
`@@ -42,12 +42,8 @@ private void NavView_Loaded(object sender, RoutedEventArgs e)`
`42`	`42`
`43`	`43`	`private void NavView_ItemInvoked(NavigationView sender, NavigationViewItemInvokedEventArgs args)`
`44`	`44`	`{`
`45`		`- var selectedItem = args.InvokedItem;`
`46`		`-`
`47`		`- if (selectedItem is not null)`
`48`		`- {`
`49`		`- Navigate(selectedItem.ToString()!);`
`50`		`- }`
	`45`	`+ var selectedItem = args.InvokedItemContainer;`
	`46`	`+ Navigate((selectedItem.Tag as string)!);`
`51`	`47`	`}`
`52`	`48`
`53`	`49`	`private void Navigate(string page)`