perf: do not duplicate nodes when indexing

Signed-off-by: Vincent Biret <[email protected]>

Author: baywet

src/Microsoft.OpenApi/Reader/ParseNodes/MapNode.cs

@@ -24,7 +24,7 @@ private PropertyNode GetPropertyNodeFromJsonNode(string key, JsonNode? node)
             return new PropertyNode(Context, key, node ?? JsonNullSentinel.JsonNull);
 		}
 
-        private readonly List<PropertyNode> _nodes;
+        private readonly Dictionary<string, PropertyNode> _nodes;
         public MapNode(ParsingContext context, JsonNode node) : base(
             context, node)
         {
@@ -34,16 +34,16 @@ public MapNode(ParsingContext context, JsonNode node) : base(
             }
 
             _node = mapNode;
-            _nodes = _node.Select(p => GetPropertyNodeFromJsonNode(p.Key, p.Value)).ToList();
+            _nodes = _node.ToDictionary(static p => p.Key, p => GetPropertyNodeFromJsonNode(p.Key, p.Value), StringComparer.Ordinal);
         }
 
         public PropertyNode? this[string key]
         {
             get
             {
-                if (_node.TryGetPropertyValue(key, out var value))
+                if (_node.ContainsKey(key))
 				{
-					return GetPropertyNodeFromJsonNode(key, value);
+					return _nodes[key];
 				}
 
                 return null;
@@ -134,7 +134,7 @@ public override Dictionary<string, HashSet<T>> CreateArrayMap<T>(Func<ValueNode,
 
         public IEnumerator<PropertyNode> GetEnumerator()
         {
-            return _nodes.GetEnumerator();
+            return _nodes.Values.GetEnumerator();
         }
 
         IEnumerator IEnumerable.GetEnumerator()