Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods used by the InputSystem should not be marked by IDE0051. #289

Open
jbevain opened this issue Aug 9, 2023 · 0 comments
Open

Methods used by the InputSystem should not be marked by IDE0051. #289

jbevain opened this issue Aug 9, 2023 · 0 comments
Labels
approved rule Indicates if the new proposed rule has been approved to move to implementation phase

Comments

@jbevain
Copy link
Member

jbevain commented Aug 9, 2023

Problem statement

The InputSystem uses private event functions:

void OnMove(InputValue value)
{
    rawInput = value.Get<Vector2>(); 
}

Which gives Private member 'Player.OnMove' is unused. [Roslyn(IDE0051)].

Proposed solution

We should suppress those suggestions. We need to check if there are naming rules for the methods or if we need to extract that from Unity metadata which would make it harder.

@sailro sailro added the approved rule Indicates if the new proposed rule has been approved to move to implementation phase label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved rule Indicates if the new proposed rule has been approved to move to implementation phase
Projects
None yet
Development

No branches or pull requests

2 participants