Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] Check size of custom objective function outputs #4905

Closed
yaxxie opened this issue Dec 22, 2021 · 3 comments
Closed

[R-package] Check size of custom objective function outputs #4905

yaxxie opened this issue Dec 22, 2021 · 3 comments

Comments

@yaxxie
Copy link
Contributor

yaxxie commented Dec 22, 2021

#4815

The above PR made changes to the python package and tests to check the outputs of the custom gradient functions conform to the assumptions made by the LGBM_BoosterUpdateOneIterCustom C-API call.
Additionally, the C-API docs were updated to make it clear that it is the callers responsbility to provide correctly sized arrays to this library call.

The R package needs updating to include this safety check as well.

@jameslamb jameslamb changed the title [R-package] Check length of gradient arrays from custom gradient functions [R-package] Check size of custom objective function outputs Dec 23, 2021
@jameslamb
Copy link
Collaborator

Thanks for writing this up and for all your help with the custom objective function stuff @yaxxie !

I've added this to #2302 with other feature requests, per this project's policy. I'm going to close it for now.

For anyone reading this...please comment if you'd like to work on this, and we can re-open it and answer questions.

@github-actions

This comment was marked as off-topic.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
@jameslamb
Copy link
Collaborator

Sorry, this was locked accidentally. Just unlocked it. We'd still love help with this feature!

@microsoft microsoft unlocked this conversation Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants