Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] Remove lgb.prepare() and lgb.prepare_rules() #3075

Closed
jameslamb opened this issue May 12, 2020 · 5 comments
Closed

[R-package] Remove lgb.prepare() and lgb.prepare_rules() #3075

jameslamb opened this issue May 12, 2020 · 5 comments

Comments

@jameslamb
Copy link
Collaborator

The R package currently has 4 functions for converting non-numeric inputs to numeric values for use with LightGBM training:

  • lgb.prepare() (docs)

  • lgb.prepare2() (docs)

  • lgb.prepare_rules() (docs)

  • lgb.prepare_rules2() (docs)

The *2() versions of these functions accomplish everything that their predecessors do, and in a better way. I think that lgb.prepare() and lgb.prepare_rules() should be deprecated in the next 2.x release, and that they should be removed completely in 3.0.0.

This will simplify the interface of the R package for users and reduce the maintenance burden for maintainers.

@Laurae2 @guolinke what do you think?

@jameslamb
Copy link
Collaborator Author

Just put this in #2302 . Will close it once I hear from the maintainers tagged in the description about whether this is a good idea.

@Laurae2
Copy link
Contributor

Laurae2 commented May 16, 2020

@jameslamb as LightGBM does not crash anymore when using an R integer matrix, we can deprecate the non *2() versions.

@jameslamb
Copy link
Collaborator Author

@Laurae2 ok thanks! I'll open a PR with a deprecation warning, and then when we do 3.0.0 (#3071 ) we can remove them

@jameslamb
Copy link
Collaborator Author

Closing for now since we've agreed on direction. This issue is in #2302 with other features.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants