-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid the use of macros as Expected #35
Comments
The |
Do you mean that C++17/20 will have Expects and Ensures as keywords? But why do you use a macro when an inline function is enough? It is so hard to read gsl::expects(x);
gsl::ensures(x); ? |
I would not label an issue as resolved when in reality it has been rejected. |
Fair enough. Fixed. |
I agree with @viboes here. I have 2 questions; 1. why is it a macro and 2. why does it not follow the coding standard of the rest of the library with regards to capitalization? |
|
Having macros that are not prefixed by the library name is a bad practice as in
Usually we use UPPERCASE letters for macros.
In addition, we have inline functions in C++, so no need for a macro that call another function ;-)
The text was updated successfully, but these errors were encountered: