Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't compile gsl_tests with VS2022: warning C4067: unexpected tokens following preprocessor directive #1155

Open
juandent opened this issue Jul 30, 2024 · 3 comments

Comments

@juandent
Copy link

Just cloned gsl and tried compiling project gsl_tests which has /WX option and the error occurs at:

#if defined(__clang__) && __has_warning("-Wunsafe-buffer-usage")

As far as I know, Visual Studio does not define clang so it should short circuit before testing __has_warning! I understand VS does not define __has_warning correct?

I compiled using /std:c++20 but I think this does not matter

@zygfrydw
Copy link

I have fixed this issue in PR1157

@beinhaerter
Copy link
Contributor

I fixed that already in #1149 in March - only waiting for it to be merged. I don't know if two PRs with the same fix help.

@zygfrydw
Copy link

zygfrydw commented Oct 3, 2024

Ohh, I have not noticed your fix, it just has bitten me recently so I fixed it. Seeing that your PR is not merged either I am afraid that it does not matter as there is not much maintenance going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants