Can not build with gcc13 because suggestion warning

[VictorEijkhout]

/work2/00434/eijkhout/msgsl/msgsl-4.0.0/tests/span_tests.cpp:333:33: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
    int arr3d[2][3][2] = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12};
                                ^~~~
                                {   }

Can I turn off the Werror? Alternatively, this seems to be non-essential testing code, so can I not build the tests?

[dmitrykobets-msft]

Hi @VictorEijkhout, I'll bring this up in the next maintainers' sync.

[jpr42]

Alternatively, this seems to be non-essential testing code, so can I not build the tests?

You can set -D GSL_TEST=OFF when configuring the CMake build.

This is also what vcpkg does in it's portfile.

https://github.com/microsoft/vcpkg/blob/b40de44891dc1cab11d4722094ae44807a837b98/ports/ms-gsl/portfile.cmake#L13

[hsutter]

Maintainers call: Yes this should be

int arr3d[2][3][2] = { { {1, 2}, {3, 4}, {5, 6} }, { {7, 8}, {9, 10}, {11, 12} } };