Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducing paper results #1

Open
nino-vieillard opened this issue Sep 18, 2020 · 4 comments
Open

Reproducing paper results #1

nino-vieillard opened this issue Sep 18, 2020 · 4 comments

Comments

@nino-vieillard
Copy link

nino-vieillard commented Sep 18, 2020

Hi,
I am trying to evaluate FQF, to use it as a baseline on some discrete environments. However, I encountered an issue: the script run-iqn.sh [EDIT: run-fqf.sh] does not seem to evaluate FQF, but actually IQN. I think the problem comes from the function create_agent in dopamine/discrete_domains/run_experiment.py can only create Rainbow, DQN and IQN (and not FQF). It is possible I missed something, could you explain how I can use this code to evaluate FQF?
Thanks,
Nino

@waterblue13
Copy link
Contributor

Hi,
I am trying to evaluate FQF, to use it as a baseline on some discrete environments. However, I encountered an issue: the script run-iqn.sh does not seem to evaluate FQF, but actually IQN. I think the problem comes from the function create_agent in dopamine/discrete_domains/run_experiment.py can only create Rainbow, DQN and IQN (and not FQF). It is possible I missed something, could you explain how I can use this code to evaluate FQF?
Thanks,
Nino

Maybe you can try run-fqf.sh.

@nino-vieillard
Copy link
Author

Hi,
I am trying to evaluate FQF, to use it as a baseline on some discrete environments. However, I encountered an issue: the script run-iqn.sh does not seem to evaluate FQF, but actually IQN. I think the problem comes from the function create_agent in dopamine/discrete_domains/run_experiment.py can only create Rainbow, DQN and IQN (and not FQF). It is possible I missed something, could you explain how I can use this code to evaluate FQF?
Thanks,
Nino

Maybe you can try run-fqf.sh.

Hi,
Sorry for the typo, I meant that run-fqf.sh seems to run IQN, not FQF.

@LinZichuan
Copy link
Contributor

LinZichuan commented Sep 22, 2020

Hi,
I am trying to evaluate FQF, to use it as a baseline on some discrete environments. However, I encountered an issue: the script run-iqn.sh does not seem to evaluate FQF, but actually IQN. I think the problem comes from the function create_agent in dopamine/discrete_domains/run_experiment.py can only create Rainbow, DQN and IQN (and not FQF). It is possible I missed something, could you explain how I can use this code to evaluate FQF?
Thanks,
Nino

Maybe you can try run-fqf.sh.

Hi,
Sorry for the typo, I meant that run-fqf.sh seems to run IQN, not FQF.

Thanks for pointing out this issue!

This is caused by a typo (agent_name='implicit_quantile' should be agent_name='fqf') in agents/fqf/configs/fqf.gin when we refactor our code. And also you can add an FQFAgent in the create_agent function of dopamine/discrete_domains/run_experiment.py.

We will update the code later. Thanks!

@LinZichuan
Copy link
Contributor

The code has been updated. @nino-vieillard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants