-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark removed types as deprecated #138
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of requests:
- I feel like this should be a periodic cleanup task rather than something that runs every publish. So maybe this should be a standalone scripty package like retag, or even a script in DT proper.
- I'm curious about the list of affected packages and their deprecation messages. Can you dump those here? I want to know what that looks like before taking this change.
@orta can you review the graphql? I think you know it the best of any of us on the team. (It looks plausible to me though.)
6fba113
to
a14ab1a
Compare
Done ✔️
Currently the following five: Deprecating fingerprintjs2
Deprecating @types/fingerprintjs2 with message: 🤖 Merge PR #48103 feat: add fingerprintjs__fingerprintjs types by @lb… (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48103)
Deprecating openapi-v3
Deprecating @types/openapi-v3 with message: Removed OpenApi-v3 types (#46819) (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46819)
Deprecating fingerprintjs
Deprecating @types/fingerprintjs with message: 🤖 Merge PR #48103 feat: add fingerprintjs__fingerprintjs types by @lb… (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48103)
Deprecating markerclustererplus
Deprecating @types/markerclustererplus with message: Change folder name to google__markerclustererplus to match scoped pac… (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/42121)
Deprecating storybook__polymer
Deprecating @types/storybook__polymer with message: [storybook__polymer] Remove types (#48796) (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48796) |
@sandersn, would you mind updating your review? I’m fine with this, but the package.json needs |
266c409
to
cacb5ca
Compare
b48db9d
to
76e48bb
Compare
020fdef
to
44c24a2
Compare
8b8d9cb
to
c87e95b
Compare
1377299
to
e88c032
Compare
Loop over the
@types
npm packages and mark any that no longer exist in HEAD (either in thetypes
directory or innotNeededPackages.json
) as deprecated.