Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark removed types as deprecated #138

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Oct 19, 2020

Loop over the @types npm packages and mark any that no longer exist in HEAD (either in the types directory or in notNeededPackages.json) as deprecated.

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of requests:

  1. I feel like this should be a periodic cleanup task rather than something that runs every publish. So maybe this should be a standalone scripty package like retag, or even a script in DT proper.
  2. I'm curious about the list of affected packages and their deprecation messages. Can you dump those here? I want to know what that looks like before taking this change.

@orta can you review the graphql? I think you know it the best of any of us on the team. (It looks plausible to me though.)

packages/publisher/src/publish-packages.ts Outdated Show resolved Hide resolved
packages/publisher/src/publish-packages.ts Outdated Show resolved Hide resolved
@jablko jablko force-pushed the patch-24 branch 3 times, most recently from 6fba113 to a14ab1a Compare October 27, 2020 14:33
@jablko
Copy link
Contributor Author

jablko commented Oct 27, 2020

  1. I feel like this should be a periodic cleanup task rather than something that runs every publish. So maybe this should be a standalone scripty package like retag, or even a script in DT proper.

Done ✔️

  1. I'm curious about the list of affected packages and their deprecation messages. Can you dump those here? I want to know what that looks like before taking this change.

Currently the following five:

Deprecating fingerprintjs2
Deprecating @types/fingerprintjs2 with message: 🤖 Merge PR #48103 feat: add fingerprintjs__fingerprintjs types by @lb… (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48103)
Deprecating openapi-v3
Deprecating @types/openapi-v3 with message: Removed OpenApi-v3 types (#46819) (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46819)
Deprecating fingerprintjs
Deprecating @types/fingerprintjs with message: 🤖 Merge PR #48103 feat: add fingerprintjs__fingerprintjs types by @lb… (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48103)
Deprecating markerclustererplus
Deprecating @types/markerclustererplus with message: Change folder name to google__markerclustererplus to match scoped pac… (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/42121)
Deprecating storybook__polymer
Deprecating @types/storybook__polymer with message: [storybook__polymer] Remove types (#48796) (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48796)

@andrewbranch
Copy link
Member

@sandersn, would you mind updating your review?

I’m fine with this, but the package.json needs private: true so lerna doesn’t publish it, and there needs to be a README that says what it does.

@jablko jablko force-pushed the patch-24 branch 16 times, most recently from 266c409 to cacb5ca Compare May 9, 2022 18:37
@jablko jablko force-pushed the patch-24 branch 3 times, most recently from b48db9d to 76e48bb Compare June 1, 2022 20:39
@jablko jablko force-pushed the patch-24 branch 4 times, most recently from 020fdef to 44c24a2 Compare June 20, 2022 14:52
@jablko jablko force-pushed the patch-24 branch 5 times, most recently from 8b8d9cb to c87e95b Compare June 30, 2022 17:29
@jablko jablko force-pushed the patch-24 branch 11 times, most recently from 1377299 to e88c032 Compare July 9, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants