-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from internal expect rule to eslint-plugin-expect-type #858
Comments
I'm not sure how we can do that. Our plugin has to loop and run on every version of typescript. That seems like a lot of extra work for an external plugin to take on (and for us to no longer be able to quickly fix). |
At the very least, I wonder if Alternately, I wonder if it would make sense to consider |
The only interesting things missing from your plugin are |
#843 migrated the old TSLint Expect rule to an ESLint rule (🥳!). Great!
There exists a community plugin for roughly the same area of functionality already: https://github.com/JoshuaKGoldberg/eslint-plugin-expect-type 1. It would be great if we could use the standard plugin instead. That way bugfixes + features from DT usage can help other community members, and vice versa.
Proposal:
eslint-plugin-expect-type
Per later comments, tracking issues in
eslint-plugin-expect-type
for missing features:Footnotes
I do feel a bit weird promoting a package with my name on it. If it helps, I didn't create it - just took over maintenance when the previous maintainer didn't have time. If there's a better alternative to
eslint-plugin-expect-type
that'd be great too! ↩The text was updated successfully, but these errors were encountered: