Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore replacing http-parser #1910

Closed
eddyashton opened this issue Nov 20, 2020 · 1 comment · Fixed by #1913
Closed

Explore replacing http-parser #1910

eddyashton opened this issue Nov 20, 2020 · 1 comment · Fixed by #1913
Labels
dependencies Pull requests that update a dependency file enhancement

Comments

@eddyashton
Copy link
Member

eddyashton commented Nov 20, 2020 •
edited
Loading

The http-parser lib we currently use is no longer maintained. This isn't an urgent issue, but we should look at moving to a supported replacement, perhaps the recommended llhttp.
@eddyashton eddyashton added enhancement TODO dependencies Pull requests that update a dependency file labels Nov 20, 2020
@eddyashton
Copy link
Member Author

Brief notes from an initial look at llhttp:

  • The generated sources + headers aren't checked in, but are prebuilt for each release. So our 3rdparty/llhttp would be a release tar rather than a git clone.
  • The feature parity claim isn't entirely true. llhttp is missing the URL parser functions from http-parser, and afaict its also missing friendly status code definitions (ie - there's no HTTP_STATUS_OK).

@eddyashton eddyashton mentioned this issue Nov 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace http-parser with llhttp eddyashton/CCF
1 participant
@eddyashton