-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Botbuilder dependency #42
Comments
Hi , my bot can't start with the following error :
It sounds similar to the @spezam one. @spezam can you please more precisely detail what did you do ? My bot previously worked without anything specified for BoBuilder. |
Hi @angegar,
|
Hi @spezam , In the package.json i added the botbuilder dependency : "dependencies": {
"aws-sdk": "^2.310.0",
"hubot": "^3.1.1",
"hubot-auth": "^2.1.0",
"hubot-botframework": "https://github.com/Microsoft/BotFramework-Hubot.git",
"hubot-diagnostics": "^1.0.0",
"hubot-redis-brain": "^1.0.0",
"node-ssh": "^5.1.2",
"winston": "^3.0.0",
"fs":"^0.0.1-security",
"xml2js":"^0.4.19",
"botbuilder": "3.15.0"
}, Then in my docker file i run :
So if i well understand it should install the good version of botbuilder. Finally i start my bot with :
But i still have the same issue. |
That should do the trick. Did you check what version of the botframework is in the container? Also, I would try to change just for testing. |
@spezam , For information the bug was i copied th package.json before the hubot installation, thus i guess that the chat bot installation override my package.json that explain why putting the botBuilder version in package.json did not work. |
Glad it worked! Now I remember why I did the npm install on startup. I'll PR a fix to the package.json, as it seems nobody has a good solution to make it work with more recent versions of botbuilder. |
Please review this if you folks have a chance: #44 |
@MattSFT As an FYI, I just created a new hubot via the instructions in the README and ran into the same issue. Doing a |
For anyone else experiencing this issue I had to make sure I was using the git url as above for |
Alternatively add a resolutions section to your package.json
|
In package.json botbuilder dependency is defined as
"botbuilder": ">=3.5.0"
Since botbuilder moved from version 3.15.0 to 4.0.6 the framework is downloading the latest and greates. Unfortunately Hubot is throwing an error on startup:
[Thu Oct 04 2018 05:22:21 GMT+0000 (UTC)] ERROR Cannot load adapter botframework - TypeError: BotBuilder.ChatConnector is not a constructor
rolling back to 3.5.0 fix the issues.
The text was updated successfully, but these errors were encountered: