diff --git a/Composer/packages/ui-plugins/select-dialog/src/SelectDialogMenu.tsx b/Composer/packages/ui-plugins/select-dialog/src/SelectDialogMenu.tsx index 5d4e7529eb..fb9367cd0e 100644 --- a/Composer/packages/ui-plugins/select-dialog/src/SelectDialogMenu.tsx +++ b/Composer/packages/ui-plugins/select-dialog/src/SelectDialogMenu.tsx @@ -121,6 +121,7 @@ export const SelectDialogMenu: React.FC = (props) => { text: d.displayName, isSelected: value === d.displayName, data: d, + role: 'option', iconProps: { iconName: getIconName(d), styles: { @@ -141,6 +142,7 @@ export const SelectDialogMenu: React.FC = (props) => { sectionProps: { items: dialogItems, }, + role: 'option', }, { key: 'actions', @@ -154,6 +156,7 @@ export const SelectDialogMenu: React.FC = (props) => { iconProps: { iconName: Icons.EXPRESSION, }, + role: 'option', }, { key: ADD_DIALOG, @@ -161,6 +164,7 @@ export const SelectDialogMenu: React.FC = (props) => { iconProps: { iconName: 'Add', }, + role: 'option', }, ], }, @@ -266,6 +270,7 @@ export const SelectDialogMenu: React.FC = (props) => { } `, }} + role="listbox" styles={buttonStyles} text={selectedLabel || ' '} onBlur={() => onBlur?.(id, value)} diff --git a/Composer/packages/ui-plugins/select-dialog/src/__tests__/selectDialog.test.tsx b/Composer/packages/ui-plugins/select-dialog/src/__tests__/selectDialog.test.tsx index c70c6467ef..6065da2a80 100644 --- a/Composer/packages/ui-plugins/select-dialog/src/__tests__/selectDialog.test.tsx +++ b/Composer/packages/ui-plugins/select-dialog/src/__tests__/selectDialog.test.tsx @@ -58,7 +58,7 @@ describe('Select Dialog', () => { const menu = await findByLabelText('Dialog name'); fireEvent.click(menu); - const createItem = getAllByRole(baseElement, 'menuitem').pop(); + const createItem = getAllByRole(baseElement, 'option').pop(); expect(createItem).toHaveTextContent('Create a new dialog'); act(() => { fireEvent.click(createItem); @@ -79,7 +79,7 @@ describe('Select Dialog', () => { const menu = await findByLabelText('Dialog name'); fireEvent.click(menu); - const [dialog] = getAllByRole(baseElement, 'menuitem'); + const [dialog] = getAllByRole(baseElement, 'option'); expect(dialog).toHaveTextContent('dialog2'); act(() => { fireEvent.click(dialog);