From 873cd57c2edef5b5814a2ae4bc60edfc3881b970 Mon Sep 17 00:00:00 2001 From: Patrick Volum Date: Mon, 19 Apr 2021 21:52:41 -0400 Subject: [PATCH 01/14] Make firendly link and add blank targer for broken azure link --- .../azurePublish/src/components/ChooseProvisionAction.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/extensions/azurePublish/src/components/ChooseProvisionAction.tsx b/extensions/azurePublish/src/components/ChooseProvisionAction.tsx index c12465617b..333e84b352 100644 --- a/extensions/azurePublish/src/components/ChooseProvisionAction.tsx +++ b/extensions/azurePublish/src/components/ChooseProvisionAction.tsx @@ -81,7 +81,9 @@ const CreateActionContent = () => { 'Select this option when you want to provision new Azure resources and publish a bot. A subscription to ' )} - {formatMessage('Microsoft Azure')} + + {formatMessage('Microsoft Azure')} + {formatMessage(' is required.')}
From 9226ae177f5ccf5871bd8829c541787bb8bb51ea Mon Sep 17 00:00:00 2001 From: Patrick Volum Date: Mon, 19 Apr 2021 22:28:50 -0400 Subject: [PATCH 02/14] Fix scrollilng in publish modal --- .../azurePublish/src/components/ChooseProvisionAction.tsx | 1 + .../azurePublish/src/components/azureProvisionDialog.tsx | 8 ++------ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/extensions/azurePublish/src/components/ChooseProvisionAction.tsx b/extensions/azurePublish/src/components/ChooseProvisionAction.tsx index 333e84b352..145d7fc3d6 100644 --- a/extensions/azurePublish/src/components/ChooseProvisionAction.tsx +++ b/extensions/azurePublish/src/components/ChooseProvisionAction.tsx @@ -28,6 +28,7 @@ const ChoicesPane = styled.div` const ContentPane = styled(Stack)` border-left: 1px solid ${NeutralColors.gray30}; height: 100%; + overflow-y: auto; `; const Content = styled(Stack)` diff --git a/extensions/azurePublish/src/components/azureProvisionDialog.tsx b/extensions/azurePublish/src/components/azureProvisionDialog.tsx index a045078cf4..a88d7aa215 100644 --- a/extensions/azurePublish/src/components/azureProvisionDialog.tsx +++ b/extensions/azurePublish/src/components/azureProvisionDialog.tsx @@ -725,18 +725,14 @@ export const AzureProvisionDialog: React.FC = () => { const resourceGroupNames = resourceGroups?.map((r) => r.name) || []; const PageChooseAction = ( - +
{ updateFormData('creationType', choice); }} /> - +
); const PageFormConfig = ( From 22785626870c4212975c92eefb9978e2638e9516 Mon Sep 17 00:00:00 2001 From: Patrick Volum Date: Mon, 19 Apr 2021 22:37:45 -0400 Subject: [PATCH 03/14] Fixed comment box in publish confirm modal --- Composer/packages/client/src/pages/publish/PublishDialog.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Composer/packages/client/src/pages/publish/PublishDialog.tsx b/Composer/packages/client/src/pages/publish/PublishDialog.tsx index 37963b6f65..5a3cdd8431 100644 --- a/Composer/packages/client/src/pages/publish/PublishDialog.tsx +++ b/Composer/packages/client/src/pages/publish/PublishDialog.tsx @@ -49,8 +49,8 @@ export const PublishDialog = (props) => { name: formatMessage('Comments'), className: 'comment', fieldName: 'comment', - minWidth: 70, - maxWidth: 90, + minWidth: 200, + maxWidth: 290, data: 'string', onRender: (item: BotStatus) => { // message for each publish bot From 78d16b1cd757ff0c851eb06ce22d24cd9b32a569 Mon Sep 17 00:00:00 2001 From: Patrick Volum Date: Mon, 19 Apr 2021 23:11:40 -0400 Subject: [PATCH 04/14] configure resource ui fix #6886 --- .../PublishProfileDialog.tsx | 4 ++-- .../src/components/ChooseProvisionAction.tsx | 3 +-- .../src/components/azureProvisionDialog.tsx | 16 +++++++++++++++- 3 files changed, 18 insertions(+), 5 deletions(-) diff --git a/Composer/packages/client/src/pages/botProject/create-publish-profile/PublishProfileDialog.tsx b/Composer/packages/client/src/pages/botProject/create-publish-profile/PublishProfileDialog.tsx index cb963d5ea6..a134ca1094 100644 --- a/Composer/packages/client/src/pages/botProject/create-publish-profile/PublishProfileDialog.tsx +++ b/Composer/packages/client/src/pages/botProject/create-publish-profile/PublishProfileDialog.tsx @@ -47,7 +47,7 @@ export const PublishProfileDialog: React.FC = (props) const { provisionToTarget, addNotification } = useRecoilValue(dispatcherState); const [dialogTitle, setTitle] = useState({ - title: current ? formatMessage('Edit a publishing profile') : formatMessage('Add a publishing profile'), + title: current ? formatMessage('Edit a publishing profile') : formatMessage('Add new publishing profile'), subText: formatMessage('A publishing profile provides the secure connectivity required to publish your bot. '), }); @@ -81,7 +81,7 @@ export const PublishProfileDialog: React.FC = (props) PluginAPI.publish.onBack = () => { setPage(Page.ProfileForm); setTitle({ - title: current ? formatMessage('Edit a publishing profile') : formatMessage('Add a publishing profile'), + title: current ? formatMessage('Edit a publishing profile') : formatMessage('Add new publishing profile'), subText: formatMessage('A publishing profile provides the secure connectivity required to publish your bot. '), }); }; diff --git a/extensions/azurePublish/src/components/ChooseProvisionAction.tsx b/extensions/azurePublish/src/components/ChooseProvisionAction.tsx index 145d7fc3d6..78fe20f5a9 100644 --- a/extensions/azurePublish/src/components/ChooseProvisionAction.tsx +++ b/extensions/azurePublish/src/components/ChooseProvisionAction.tsx @@ -75,7 +75,6 @@ const LearnMoreLink = styled(Link)` const CreateActionContent = () => { return ( - {formatMessage('Create New Resources')} {formatMessage( @@ -115,7 +114,7 @@ const CreateActionContent = () => {
- + {formatMessage('Learn More')} diff --git a/extensions/azurePublish/src/components/azureProvisionDialog.tsx b/extensions/azurePublish/src/components/azureProvisionDialog.tsx index a88d7aa215..b59912aafd 100644 --- a/extensions/azurePublish/src/components/azureProvisionDialog.tsx +++ b/extensions/azurePublish/src/components/azureProvisionDialog.tsx @@ -96,7 +96,7 @@ const PageTypes = { const DialogTitle = { CHOOSE_ACTION: { - title: formatMessage('Configure resources'), + title: formatMessage('Configure resources to your publishing profile'), subText: formatMessage('How you would like to provision Azure resources to your publishing profile?'), }, CONFIG_RESOURCES: { @@ -937,6 +937,13 @@ export const AzureProvisionDialog: React.FC = () => { } }} /> + { + closeDialog(); + }} + /> ); @@ -1048,6 +1055,13 @@ export const AzureProvisionDialog: React.FC = () => { } }} /> + { + closeDialog(); + }} + /> ); From 346c5e1e56e80891a7e36ad91723098b96567b9f Mon Sep 17 00:00:00 2001 From: Patrick Volum Date: Mon, 19 Apr 2021 23:25:12 -0400 Subject: [PATCH 05/14] import existing resources fit and finish #6889 --- .../src/components/azureProvisionDialog.tsx | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/extensions/azurePublish/src/components/azureProvisionDialog.tsx b/extensions/azurePublish/src/components/azureProvisionDialog.tsx index b59912aafd..dd98e10f9d 100644 --- a/extensions/azurePublish/src/components/azureProvisionDialog.tsx +++ b/extensions/azurePublish/src/components/azureProvisionDialog.tsx @@ -100,8 +100,8 @@ const DialogTitle = { subText: formatMessage('How you would like to provision Azure resources to your publishing profile?'), }, CONFIG_RESOURCES: { - title: formatMessage('Configure resources'), - subText: formatMessage('How you would like to provision your Azure resources to publish your bot?'), + title: formatMessage('Import existing resources'), + subText: formatMessage('Please provide your Publish Configuration'), }, ADD_RESOURCES: { title: formatMessage('Add resources'), @@ -1110,17 +1110,24 @@ export const AzureProvisionDialog: React.FC = () => { <> { - closeDialog(); + setPageAndTitle(PageTypes.ChooseAction); }} /> + { + closeDialog(); + }} + /> ); } From e13ffc279758769c6ca4cdc6e546e5dd224c3617 Mon Sep 17 00:00:00 2001 From: Patrick Volum Date: Tue, 20 Apr 2021 11:51:54 -0400 Subject: [PATCH 06/14] #7132: standardizing qna plural/singular resource strings --- .../packages/client/src/components/ManageQNA/ManageQNA.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx b/Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx index 63495c7598..2c44f6df15 100644 --- a/Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx +++ b/Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx @@ -518,7 +518,7 @@ export const ManageQNA = (props: ManageQNAProps) => {