Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: Show speech modality when the activity includes input hint #6942

Merged
tdurnford merged 5 commits into from
Apr 14, 2021
Merged

fix: Show speech modality when the activity includes input hint #6942

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e100866
fix: Show speech modality when the activity includes input hint
tdurnford Apr 14, 2021
17f812a
Merge branch 'main' into durnford/fix/input-hint
tdurnford Apr 14, 2021
8c3c7a2
lint
tdurnford Apr 14, 2021
5921aec
revert en-us changes
tdurnford Apr 14, 2021
adf83e5
Merge branch 'durnford/fix/input-hint' of github.com:microsoft/BotFra…
tdurnford Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Composer/packages/lib/code-editor/src/lg/ModalityPivot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,11 @@ const getInitialModalities = (structuredResponse?: PartialStructuredResponse): M
const modalities = Object.keys(structuredResponse || {}).filter((m) =>
modalityTypes.includes(m as ModalityType)
) as ModalityType[];

if (structuredResponse?.InputHint && !structuredResponse.Speak) {
modalities.push('Speak');
}

return modalities.length ? modalities : ['Text'];
};

Expand Down Expand Up @@ -284,6 +289,11 @@ export const ModalityPivot = React.memo((props: Props) => {
const mergedResponse = mergeWith({}, structuredResponse) as PartialStructuredResponse;
delete mergedResponse[modality];

// Remove Input Hint when the user deletes the Speech modality
if (modality === 'Speak') {
delete mergedResponse.InputHint;
}

setStructuredResponse(mergedResponse);
const mappedResponse = structuredResponseToString(mergedResponse);
onTemplateChange(lgOption.templateId, mappedResponse);
Expand Down