Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: miss passing defaultLanguage as parameter #6820

Merged
boydc2014 merged 1 commit into from
Apr 9, 2021
Merged

fix: miss passing defaultLanguage as parameter #6820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions Composer/packages/client/src/recoilModel/Recognizers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,17 +143,30 @@ export const generateRecognizers = (
dialog: DialogInfo,
luFiles: LuFile[],
qnaFiles: QnAFile[],
luProvide?: LuProviderType
luProvide?: LuProviderType,
defaultLanguage = 'en-us'
) => {
const isCrossTrain = isCrossTrainedRecognizerSet(dialog);
const luisRecognizers =
luProvide === SDKKinds.OrchestratorRecognizer
? getOrchestratorRecognizerDialogs(dialog.id, luFiles)
: getLuisRecognizerDialogs(dialog.id, luFiles);
const luMultiLanguageRecognizer = getMultiLanguagueRecognizerDialog(dialog.id, luFiles, 'lu', LUISLocales);
const luMultiLanguageRecognizer = getMultiLanguagueRecognizerDialog(
dialog.id,
luFiles,
'lu',
LUISLocales,
defaultLanguage
);

const crossTrainedRecognizer = getCrossTrainedRecognizerDialog(dialog.id, luFiles, qnaFiles);
const qnaMultiLanguagueRecognizer = getMultiLanguagueRecognizerDialog(dialog.id, qnaFiles, 'qna', QnALocales);
const qnaMultiLanguagueRecognizer = getMultiLanguagueRecognizerDialog(
dialog.id,
qnaFiles,
'qna',
QnALocales,
defaultLanguage
);
const qnaMakeRecognizers = getQnAMakerRecognizerDialogs(dialog.id, qnaFiles);

return {
Expand Down Expand Up @@ -185,6 +198,7 @@ export const Recognizer = React.memo((props: { projectId: string }) => {
const luFiles = useRecoilValue(luFilesSelectorFamily(projectId));
const qnaFiles = useRecoilValue(qnaFilesSelectorFamily(projectId));
const settings = useRecoilValue(settingsState(projectId));
const defaultLanguage = settings.defaultLanguage;
const curRecognizers = useRecoilValue(recognizersSelectorFamily(projectId));
const curRecognizersRef = useRef(curRecognizers);
const filePersistence = useRecoilValue(filePersistenceState(projectId));
Expand All @@ -207,7 +221,7 @@ export const Recognizer = React.memo((props: { projectId: string }) => {
crossTrainedRecognizer,
qnaMultiLanguagueRecognizer,
qnaMakeRecognizers,
} = generateRecognizers(dialog, filteredLus, filteredQnas, luProvide);
} = generateRecognizers(dialog, filteredLus, filteredQnas, luProvide, defaultLanguage);

if (luisRecognizers.length) {
recognizers.push(luMultiLanguageRecognizer);
Expand All @@ -224,7 +238,7 @@ export const Recognizer = React.memo((props: { projectId: string }) => {
if (!isEqual([...recognizers].sort(), [...curRecognizersRef.current].sort())) {
setRecognizers(recognizers);
}
}, [dialogs, luFiles, qnaFiles, filePersistence]);
}, [dialogs, luFiles, qnaFiles, filePersistence, defaultLanguage]);

useEffect(() => {
try {
Expand Down