From e5b740b42703527a2bacb35c692efcee62508159 Mon Sep 17 00:00:00 2001 From: liweitian Date: Fri, 9 Apr 2021 15:59:30 +0800 Subject: [PATCH] miss passing defaultLanguage as parameter --- .../client/src/recoilModel/Recognizers.tsx | 24 +++++++++++++++---- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/Composer/packages/client/src/recoilModel/Recognizers.tsx b/Composer/packages/client/src/recoilModel/Recognizers.tsx index e1e8214926..23e189a441 100644 --- a/Composer/packages/client/src/recoilModel/Recognizers.tsx +++ b/Composer/packages/client/src/recoilModel/Recognizers.tsx @@ -143,17 +143,30 @@ export const generateRecognizers = ( dialog: DialogInfo, luFiles: LuFile[], qnaFiles: QnAFile[], - luProvide?: LuProviderType + luProvide?: LuProviderType, + defaultLanguage = 'en-us' ) => { const isCrossTrain = isCrossTrainedRecognizerSet(dialog); const luisRecognizers = luProvide === SDKKinds.OrchestratorRecognizer ? getOrchestratorRecognizerDialogs(dialog.id, luFiles) : getLuisRecognizerDialogs(dialog.id, luFiles); - const luMultiLanguageRecognizer = getMultiLanguagueRecognizerDialog(dialog.id, luFiles, 'lu', LUISLocales); + const luMultiLanguageRecognizer = getMultiLanguagueRecognizerDialog( + dialog.id, + luFiles, + 'lu', + LUISLocales, + defaultLanguage + ); const crossTrainedRecognizer = getCrossTrainedRecognizerDialog(dialog.id, luFiles, qnaFiles); - const qnaMultiLanguagueRecognizer = getMultiLanguagueRecognizerDialog(dialog.id, qnaFiles, 'qna', QnALocales); + const qnaMultiLanguagueRecognizer = getMultiLanguagueRecognizerDialog( + dialog.id, + qnaFiles, + 'qna', + QnALocales, + defaultLanguage + ); const qnaMakeRecognizers = getQnAMakerRecognizerDialogs(dialog.id, qnaFiles); return { @@ -185,6 +198,7 @@ export const Recognizer = React.memo((props: { projectId: string }) => { const luFiles = useRecoilValue(luFilesSelectorFamily(projectId)); const qnaFiles = useRecoilValue(qnaFilesSelectorFamily(projectId)); const settings = useRecoilValue(settingsState(projectId)); + const defaultLanguage = settings.defaultLanguage; const curRecognizers = useRecoilValue(recognizersSelectorFamily(projectId)); const curRecognizersRef = useRef(curRecognizers); const filePersistence = useRecoilValue(filePersistenceState(projectId)); @@ -207,7 +221,7 @@ export const Recognizer = React.memo((props: { projectId: string }) => { crossTrainedRecognizer, qnaMultiLanguagueRecognizer, qnaMakeRecognizers, - } = generateRecognizers(dialog, filteredLus, filteredQnas, luProvide); + } = generateRecognizers(dialog, filteredLus, filteredQnas, luProvide, defaultLanguage); if (luisRecognizers.length) { recognizers.push(luMultiLanguageRecognizer); @@ -224,7 +238,7 @@ export const Recognizer = React.memo((props: { projectId: string }) => { if (!isEqual([...recognizers].sort(), [...curRecognizersRef.current].sort())) { setRecognizers(recognizers); } - }, [dialogs, luFiles, qnaFiles, filePersistence]); + }, [dialogs, luFiles, qnaFiles, filePersistence, defaultLanguage]); useEffect(() => { try {