This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: detect "old" bots and migrate them to new runtime #6526
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| import get from 'lodash/get'; | ||
| import set from 'lodash/set'; | ||
| import cloneDeep from 'lodash/cloneDeep'; | ||
| import { useRecoilValue } from 'recoil'; | ||
| import { useEffect } from 'react'; | ||
|
|
||
| import { DiagnosticType, SchemaDiagnostic } from '../../../../diagnostics/types'; | ||
| import { botProjectSpaceSelector, dispatcherState } from '../../../../../recoilModel'; | ||
|
|
||
| import { useDiagnosticsData } from './useDiagnostics'; | ||
|
|
||
| export const useAutoFix = () => { | ||
| const diagnostics = useDiagnosticsData(); | ||
| const botProjectSpace = useRecoilValue(botProjectSpaceSelector); | ||
| const { updateDialog } = useRecoilValue(dispatcherState); | ||
|
|
||
| // Auto fix schema absence by setting 'disabled' to true. | ||
| useEffect(() => { | ||
| const schemaDiagnostics = diagnostics.filter((d) => d.type === DiagnosticType.SCHEMA) as SchemaDiagnostic[]; | ||
| /** | ||
| * Aggregated diagnostic paths where contains schema problem | ||
| * | ||
| * Example: | ||
| * { | ||
| * // projectId | ||
| * '2096.637': { | ||
| * // dialogId | ||
| * 'dialog-1': [ | ||
| * 'triggers[0].actions[1]', // diagnostics.dialogPath | ||
| * 'triggers[2].actions[3]' | ||
| * ] | ||
| * } | ||
| * } | ||
| */ | ||
| const aggregatedPaths: { [projectId: string]: { [dialogId: string]: string[] } } = {}; | ||
|
|
||
| // Aggregates schema diagnostics by projectId, dialogId | ||
| schemaDiagnostics.forEach((d) => { | ||
| const { projectId, id: dialogId, dialogPath } = d; | ||
| if (!dialogPath) return; | ||
| const currentPaths = get(aggregatedPaths, [projectId, dialogId]); | ||
| if (currentPaths) { | ||
| currentPaths.push(dialogPath); | ||
| } else { | ||
| set(aggregatedPaths, [projectId, dialogId], [dialogPath]); | ||
| } | ||
| }); | ||
|
|
||
| // Consumes aggregatedPaths to update dialogs in recoil store | ||
| for (const [projectId, pathsByDialogId] of Object.entries(aggregatedPaths)) { | ||
| // Locates dialogs in current project | ||
| const dialogsInProject = botProjectSpace.find((bot) => bot.projectId === projectId)?.dialogs; | ||
| if (!Array.isArray(dialogsInProject)) continue; | ||
|
|
||
| for (const [dialogId, paths] of Object.entries(pathsByDialogId)) { | ||
| // Queries out current dialog data | ||
| const dialogData = dialogsInProject.find((dialog) => dialog.id === dialogId)?.content; | ||
| if (!dialogData) continue; | ||
|
|
||
| // Filters out those paths where action exists and action.disabled !== true | ||
| const pathsToUpdate = paths.filter((p) => { | ||
| const data = get(dialogData, p); | ||
| return data && !get(data, 'disabled'); | ||
| }); | ||
| if (!pathsToUpdate.length) continue; | ||
|
|
||
| // Manipulates the 'disabled' property and then submit to Recoil store. | ||
| const copy = cloneDeep(dialogData); | ||
| for (const p of pathsToUpdate) { | ||
| set(copy, `${p}.disabled`, true); | ||
| } | ||
| updateDialog({ id: dialogId, projectId, content: copy }); | ||
| } | ||
| } | ||
| }, [diagnostics]); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handleDismiss sets the creation flow to CLOSE and then navigates home. Is that all synchronous? This then sets the status to MIGRATE. Do you want to only set the status to one state or does this need to go through the CLOSE state?