Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: visual panel header bug on display remote skill #5953

Merged
boydc2014 merged 8 commits into from
Feb 26, 2021
Merged

fix: visual panel header bug on display remote skill #5953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4012986
fix visual panel header bug on display remote skill
zhixzhan Feb 25, 2021
057eba3
Merge branch 'main' into zhixzhan/skill-display-fix
zhixzhan Feb 25, 2021
848085c
Merge branch 'main' into zhixzhan/skill-display-fix
zhixzhan Feb 25, 2021
88d68af
Merge branch 'main' into zhixzhan/skill-display-fix
zhixzhan Feb 25, 2021
d0aa900
Merge branch 'main' into zhixzhan/skill-display-fix
zhixzhan Feb 26, 2021
acf567c
Merge branch 'main' into zhixzhan/skill-display-fix
boydc2014 Feb 26, 2021
f89a4b2
Merge branch 'main' into zhixzhan/skill-display-fix
boydc2014 Feb 26, 2021
3b7db51
Merge branch 'main' into zhixzhan/skill-display-fix
boydc2014 Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions Composer/packages/client/src/pages/design/VisualPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,15 @@ const VisualPanel: React.FC<VisualPanelProps> = React.memo(({ projectId }) => {

return (
<div aria-label={formatMessage('Authoring canvas')} css={visualPanel} role="region">
<VisualPanelHeader
pluginConfig={pluginConfig}
projectId={projectId}
showCode={dialogJsonVisible}
visible={!isRemoteSkill}
onShowCodeClick={handleShowCodeClick}
/>
{!isRemoteSkill && (
<VisualPanelHeader
pluginConfig={pluginConfig}
projectId={projectId}
showCode={dialogJsonVisible}
onShowCodeClick={handleShowCodeClick}
/>
)}

{dialogJsonVisible && currentDialog ? (
<JsonEditor
key={'dialogjson'}
Expand Down
7 changes: 3 additions & 4 deletions Composer/packages/client/src/pages/design/VisualPanelHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ type BreadcrumbItem = {

type VisualPanelHeaderProps = {
projectId: string;
visible: boolean;
showCode: boolean;
onShowCodeClick: () => void;
pluginConfig?: PluginConfig;
Expand Down Expand Up @@ -158,7 +157,7 @@ const useBreadcrumbs = (projectId: string, pluginConfig?: PluginConfig) => {
};

const VisualPanelHeader: React.FC<VisualPanelHeaderProps> = React.memo((props) => {
const { visible, showCode, projectId, onShowCodeClick, pluginConfig } = props;
const { showCode, projectId, onShowCodeClick, pluginConfig } = props;
const breadcrumbs = useBreadcrumbs(projectId, pluginConfig);

const createBreadcrumbItem: (breadcrumb: BreadcrumbItem) => IBreadcrumbItem = (breadcrumb: BreadcrumbItem) => {
Expand All @@ -171,7 +170,7 @@ const VisualPanelHeader: React.FC<VisualPanelHeaderProps> = React.memo((props) =

const items = breadcrumbs.map(createBreadcrumbItem);

return visible ? (
return (
<div style={{ display: 'flex', justifyContent: 'space-between', height: '65px' }}>
<Breadcrumb
ariaLabel={formatMessage('Navigation Path')}
Expand All @@ -187,7 +186,7 @@ const VisualPanelHeader: React.FC<VisualPanelHeaderProps> = React.memo((props) =
</ActionButton>
</div>
</div>
) : null;
);
});

export default VisualPanelHeader;