Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: add useMemo to improve performance #4701

Merged
boydc2014 merged 3 commits into from
Nov 6, 2020
Merged

fix: add useMemo to improve performance #4701

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4cd986
add useMemo to improve performance
liweitian Nov 6, 2020
45c4912
Merge branch 'main' into nameInputPerf
boydc2014 Nov 6, 2020
a4e58e2
Merge branch 'main' into nameInputPerf
boydc2014 Nov 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions Composer/packages/client/src/components/CreationFlow/DefineConversation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { DialogFooter } from 'office-ui-fabric-react/lib/Dialog';
import formatMessage from 'format-message';
import { PrimaryButton, DefaultButton } from 'office-ui-fabric-react/lib/Button';
import { Stack, StackItem } from 'office-ui-fabric-react/lib/Stack';
import React, { Fragment, useEffect, useCallback } from 'react';
import React, { Fragment, useEffect, useCallback, useMemo } from 'react';
import { TextField } from 'office-ui-fabric-react/lib/TextField';
import { RouteComponentProps } from '@reach/router';
import querystring from 'query-string';
Expand Down Expand Up @@ -212,6 +212,18 @@ const DefineConversation: React.FC<DefineConversationProps> = (props) => {
updateField('location', location);
}, [focusedStorageFolder]);

const locationSelectContent = useMemo(() => {
return (
<LocationSelectContent
createFolder={createFolder}
focusedStorageFolder={focusedStorageFolder}
operationMode={{ read: true, write: true }}
updateFolder={updateFolder}
onCurrentPathUpdate={onCurrentPathUpdateWrap}
/>
);
}, [focusedStorageFolder]);

return (
<Fragment>
<DialogWrapper
Expand Down Expand Up @@ -246,14 +258,7 @@ const DefineConversation: React.FC<DefineConversationProps> = (props) => {
/>
</StackItem>
</Stack>
<LocationSelectContent
createFolder={createFolder}
focusedStorageFolder={focusedStorageFolder}
operationMode={{ read: true, write: true }}
updateFolder={updateFolder}
onCurrentPathUpdate={onCurrentPathUpdateWrap}
/>

{locationSelectContent}
<DialogFooter>
<DefaultButton text={formatMessage('Cancel')} onClick={onDismiss} />
<PrimaryButton
Expand Down