Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: Exclude no template definition warning in LG editor #4525

Merged
cwhitten merged 2 commits into from
Oct 26, 2020
Merged

fix: Exclude no template definition warning in LG editor #4525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84d31b5
exclude no template definition warning in LG
Oct 26, 2020
23e6956
Merge branch 'main' into shuwan/removeLGEmptyFileWarn
Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Composer/packages/lib/indexers/src/lgIndexer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ const { defaultFileResolver } = TemplatesParser;

function parse(content: string, id = '', importResolver: ImportResolverDelegate = defaultFileResolver) {
const lgFile = Templates.parseText(content, id, importResolver);
lgFile.diagnostics = lgFile.diagnostics.filter(
(diag) => !diag.message.includes('LG file must have at least one template definition.')
);
return convertTemplatesToLgFile(id, content, lgFile);
}

Expand All @@ -22,6 +25,9 @@ function index(files: FileInfo[], importResolver?: ImportResolverDelegate): LgFi
if (name.endsWith('.lg')) {
const id = getBaseName(name, '.lg');
const result = parse(content, id, importResolver);
result.diagnostics = result.diagnostics.filter(
(diag) => !diag.message.includes('LG file must have at least one template definition.')
);
delete result.parseResult;
lgFiles.push(result);
}
Expand Down
7 changes: 6 additions & 1 deletion Composer/packages/tools/language-servers/language-generation/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,13 @@ export function convertDiagnostics(lgDiags: BFDiagnostic[] = [], document: TextD
message: diag.message,
source: document.uri,
};
diagnostics.push(diagnostic);

//exclude the warning of no template definition.
if (!diagnostic.message.includes('LG file must have at least one template definition.')) {
diagnostics.push(diagnostic);
}
});

return diagnostics;
}

Expand Down