Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: Luis publish missing parameter #3764

Merged
zhixzhan merged 2 commits into from
Aug 3, 2020
Merged

fix: Luis publish missing parameter #3764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a274fd0
fix luis publish
zhixzhan Aug 3, 2020
995e151
remove empty space in setting page
zhixzhan Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions Composer/packages/client/src/pages/setting/dialog-settings/DialogSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import {
import { languageListTemplates } from '../../../components/MultiLanguage';
import { navigateTo } from '../../../utils/navigation';

import { hostedControls, settingsEditor, toolbar } from './style';
import { settingsEditor, toolbar } from './style';
import { BotSettings } from './constants';

export const DialogSettings: React.FC<RouteComponentProps> = () => {
Expand Down Expand Up @@ -96,22 +96,20 @@ export const DialogSettings: React.FC<RouteComponentProps> = () => {
const editorId = [defaultLanguage, ...languages].join('-');

return botName ? (
<Stack tokens={{ childrenGap: '3rem' }}>
<Stack tokens={{ childrenGap: '1rem' }}>
<StackItem grow={0}>
<div css={hostedControls}>
<Label>{BotSettings.generalTitle}</Label>
<p>
{BotSettings.botSettingDescription}
&nbsp;
<Link href={'https://aka.ms/bf-composer-docs-publish-bot'} target="_blank">
{BotSettings.learnMore}
</Link>
</p>
</div>
<Label>{BotSettings.generalTitle}</Label>
<section>
{BotSettings.botSettingDescription}
&nbsp;
<Link href={'https://aka.ms/bf-composer-docs-publish-bot'} target="_blank">
{BotSettings.learnMore}
</Link>
</section>
</StackItem>
<StackItem>
<Label>{BotSettings.languageTitle}</Label>
<p>{BotSettings.languagesubTitle}</p>
<section>{BotSettings.languagesubTitle}</section>
<section style={{ padding: '0 50px' }}>
<div css={toolbar}>
<Dropdown
Expand Down
8 changes: 0 additions & 8 deletions Composer/packages/client/src/pages/setting/dialog-settings/style.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,6 @@ export const hostedSettings = css`
box-sizing: border-box;
`;

export const hostedControls = css`
margin-bottom: 18px;

& > h1 {
margin-top: 0;
}
`;

export const settingsEditor = css`
flex: 1;
height: 500px;
Expand Down
1 change: 1 addition & 0 deletions Composer/packages/server/src/models/bot/luPublisher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ export class LuPublisher {
config.botName,
config.suffix,
config.fallbackLocal,
true,
false,
loadResult.multiRecognizers,
loadResult.settings
Expand Down