Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: fix id factory test #3282

Merged
luhan2017 merged 1 commit into from
Jun 3, 2020
Merged

fix: fix id factory test #3282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions runtime/dotnet/tests/SkillConversationIdFactoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public async Task ShouldCreateCorrectConversationId()
BotFrameworkSkill = skill
};

var conversationId = _idFactory.CreateSkillConversationIdAsync(options, CancellationToken.None).Result;
var conversationId = await _idFactory.CreateSkillConversationIdAsync(options, CancellationToken.None);
Assert.IsNotNull(conversationId);
}

Expand Down Expand Up @@ -149,7 +149,6 @@ public async Task ShouldNotGetReferenceAfterDeleted()
private bool RefEquals(ConversationReference ref1, ConversationReference ref2)
{
return ref1.Conversation.Id == ref2.Conversation.Id && ref1.ServiceUrl == ref2.ServiceUrl;

}
}
}
Expand Down