Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

ci: update utils.ts to allow for "#minor" tag #3148

Merged
cwhitten merged 2 commits into from
May 20, 2020
Merged

ci: update utils.ts to allow for "#minor" tag #3148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9af432
Update utils.ts
beyackle May 20, 2020
150ae55
typo fix
beyackle May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/actions/conventional-pr/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ type ValidationResult = string[];

const validTypes = [
'feat',
'feature',
'fix',
'doc',
'docs',
'style',
'refactor',
Expand Down Expand Up @@ -43,7 +45,7 @@ export function validateTitle(title: string): ValidationResult {
return errors;
}

const refMatch = /(refs?|close(d|s)?|fix(ed|es)?) \#\d+/i;
const refMatch = /((refs?|close(d|s)?|fix(ed|es)?) \#\d+)|(#minor)/i;
const helpLink =
'https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords';

Expand All @@ -52,7 +54,7 @@ export function validateBody(body: string): ValidationResult {

if (!refMatch.test(body)) {
errors.push(
`[Body] Must reference an issue (ex. 'fixes #1234').\nSee ${helpLink} for more details.`
`[Body] Must either reference an issue (ex. 'fixes #1234') or, if this is a minor change with no related issue, tag it as '#minor'.\nSee ${helpLink} for more details.`
);
}

Expand Down