Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

a11y: Add name for arrow, nodeMenu and endNode #2131

Merged
cwhitten merged 4 commits into from
Mar 5, 2020
Merged

a11y: Add name for arrow, nodeMenu and endNode #2131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dfc6022
add name for nodeMenu, arrow and endNode
alanlong9278 Feb 28, 2020
7d95224
Merge branch 'master' into julong/nameForComponent
alanlong9278 Mar 4, 2020
28072ff
Merge branch 'master' into julong/nameForComponent
alanlong9278 Mar 5, 2020
6b9ae35
Merge branch 'master' into julong/nameForComponent
cwhitten Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Composer/packages/extensions/visual-designer/src/components/lib/EdgeUtil.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,14 @@ export const drawSVGEdge = (
const [p1, p2] = calculateArrowPoints(endPoint, direction);
const points = [p1, endPoint, p2].map(p => `${p.x},${p.y}`).join(' ');
const arrow = (
<polyline key={`edge-${id}__arrow`} points={points} {...strokeProps} fill="none" strokeDasharray="none" />
<polyline
key={`edge-${id}__arrow`}
name={id}
points={points}
{...strokeProps}
fill="none"
strokeDasharray="none"
/>
);
elements.push(arrow);
}
Expand Down
3 changes: 2 additions & 1 deletion Composer/packages/extensions/visual-designer/src/components/menus/NodeMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const declareElementAttributes = (id: string) => {
[AttrNames.SelectedId]: `${id}${MenuTypes.NodeMenu}`,
};
};
export const NodeMenu = ({ id, onEvent }): JSX.Element => {
export const NodeMenu = ({ id, onEvent }) => {
const menuItems = [
{
key: 'delete',
Expand All @@ -35,6 +35,7 @@ export const NodeMenu = ({ id, onEvent }): JSX.Element => {

return (
<div
data-name="nodeMenu"
css={{
marginRight: '1px',
}}
Expand Down
1 change: 1 addition & 0 deletions Composer/packages/extensions/visual-designer/src/editors/StepEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ export const StepEditor = ({ id, data, onEvent, trigger, addCoachMarkRef }): JSX
{ directed: true }
)}
<circle
name="editor__end"
r={TerminatorSize.height / 2 - 1}
cx={editorAxisX}
cy={contentBoundary.height + HeadSize.height + ElementInterval.y / 2 + TerminatorSize.height / 2}
Expand Down