diff --git a/Composer/.eslintrc.react.js b/Composer/.eslintrc.react.js index 5463727b2f..e40ee6357f 100644 --- a/Composer/.eslintrc.react.js +++ b/Composer/.eslintrc.react.js @@ -3,7 +3,7 @@ module.exports = { plugins: ['react-hooks', 'format-message', 'emotion'], settings: { react: { - version: '16.9.0', + version: '16.9.16', }, }, parserOptions: { diff --git a/Composer/README.md b/Composer/README.md index c4395a8faa..779d6016d4 100644 --- a/Composer/README.md +++ b/Composer/README.md @@ -50,7 +50,7 @@ Composer is managed via yarn workspaces, producing such a folder layout. |- server // composer api server |- extensions |- package.json // put all extension as one package - |- obiformeditor // dialog property editor + |- adaptive-form // dialog property editor |- lib |- shared // shared code ``` diff --git a/Composer/cypress/integration/NotificationPage.spec.ts b/Composer/cypress/integration/NotificationPage.spec.ts index d93e0e03ff..5b5dec6110 100644 --- a/Composer/cypress/integration/NotificationPage.spec.ts +++ b/Composer/cypress/integration/NotificationPage.spec.ts @@ -62,7 +62,13 @@ context('Notification Page', () => { cy.withinEditor('FormEditor', () => { cy.findByText('Condition').should('exist'); - cy.get('.ObjectItem input').type('()'); + cy.findByTestId('expression-type-dropdown-Condition') + .focus() + .type('{downarrow}') + .should('contain.text', 'expression'); + cy.get('#root\\.condition') + .click() + .type('()'); }); cy.get('[data-testid="notifications-info-button"]').click(); diff --git a/Composer/cypress/integration/ToDoBot.spec.ts b/Composer/cypress/integration/ToDoBot.spec.ts index 587ac63950..c9cec69b9d 100644 --- a/Composer/cypress/integration/ToDoBot.spec.ts +++ b/Composer/cypress/integration/ToDoBot.spec.ts @@ -5,6 +5,7 @@ context('ToDo Bot', () => { before(() => { cy.visit(Cypress.env('COMPOSER_URL')); cy.createBot('TodoSample'); + // eslint-disable-next-line cypress/no-unnecessary-waiting cy.wait(5000); }); diff --git a/Composer/cypress/support/index.ts b/Composer/cypress/support/index.ts index 0bbb874401..57ccbe952a 100644 --- a/Composer/cypress/support/index.ts +++ b/Composer/cypress/support/index.ts @@ -9,6 +9,7 @@ beforeEach(() => { }); after(() => { + // eslint-disable-next-line cypress/no-unnecessary-waiting cy.wait(500); cy.exec('yarn test:integration:clean'); }); diff --git a/Composer/jest.config.js b/Composer/jest.config.js index 3acf2967a6..99516d0016 100644 --- a/Composer/jest.config.js +++ b/Composer/jest.config.js @@ -39,11 +39,18 @@ module.exports = { testPathIgnorePatterns: ['/node_modules/', '/scripts/', '/jestMocks/', '__tests__/setup.(j|t)s', '/cypress/'], projects: [ '/packages/client', - '/packages/server', - '/packages/extensions/obiformeditor', + '/packages/extensions/adaptive-form', + '/packages/extensions/extension', '/packages/extensions/visual-designer', '/packages/lib/code-editor', '/packages/lib/shared', + '/packages/server', '/packages/tools/language-servers/language-generation', + '/packages/ui-plugins/expressions', + '/packages/ui-plugins/json', + '/packages/ui-plugins/lg', + '/packages/ui-plugins/luis', + '/packages/ui-plugins/prompts', + '/packages/ui-plugins/select-dialog', ], }; diff --git a/Composer/package.json b/Composer/package.json index 3b4c44915b..78ba5f0004 100644 --- a/Composer/package.json +++ b/Composer/package.json @@ -3,7 +3,7 @@ "license": "MIT", "private": true, "resolutions": { - "@types/react": "16.9.0" + "@types/react": "16.9.23" }, "engines": { "node": ">=12" @@ -17,14 +17,15 @@ "packages/lib/*", "packages/tools", "packages/tools/language-servers", - "packages/tools/language-servers/*" + "packages/tools/language-servers/*", + "packages/ui-plugins/*" ], "scripts": { "build": "node scripts/update.js && node scripts/begin.js && yarn build:prod && yarn build:plugins", "build:prod": "yarn build:dev && yarn build:server && yarn build:client", "build:dev": "yarn build:lib && yarn build:tools && yarn build:extensions && yarn build:plugins", "build:lib": "yarn workspace @bfc/libs build:all", - "build:extensions": "yarn workspace @bfc/extensions build:all", + "build:extensions": "wsrun -lt -p @bfc/extension @bfc/adaptive-form @bfc/visual-designer @bfc/ui-plugin-* -c build", "build:server": "yarn workspace @bfc/server build", "build:client": "yarn workspace @bfc/client build", "build:tools": "yarn workspace @bfc/tools build:all", @@ -71,6 +72,7 @@ "@cypress/webpack-preprocessor": "^4.1.1", "@emotion/babel-preset-css-prop": "^10.0.17", "@testing-library/cypress": "^5.2.1", + "@types/jest": "^25.1.3", "@typescript-eslint/eslint-plugin": "2.10.0", "@typescript-eslint/parser": "2.10.0", "babel-jest": "24.0.0", diff --git a/Composer/packages/client/config/webpack.config.js b/Composer/packages/client/config/webpack.config.js index f56da750fe..03916f3df3 100644 --- a/Composer/packages/client/config/webpack.config.js +++ b/Composer/packages/client/config/webpack.config.js @@ -17,7 +17,6 @@ const WatchMissingNodeModulesPlugin = require('react-dev-utils/WatchMissingNodeM const ModuleScopePlugin = require('react-dev-utils/ModuleScopePlugin'); const getCSSModuleLocalIdent = require('react-dev-utils/getCSSModuleLocalIdent'); const ModuleNotFoundPlugin = require('react-dev-utils/ModuleNotFoundPlugin'); -const MonacoWebpackPlugin = require('@bfcomposer/monaco-editor-webpack-plugin'); const getClientEnvironment = require('./env'); const paths = require('./paths'); @@ -404,10 +403,6 @@ module.exports = function(webpackEnv) { ], }, plugins: [ - new MonacoWebpackPlugin({ - // available options are documented at https://github.com/Microsoft/monaco-editor-webpack-plugin#options - languages: ['markdown', 'json'], - }), // Generates an `index.html` file with the