Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and plug up potential memory leaks from event registration #7597

Closed
craxal opened this issue Dec 15, 2023 · 1 comment
Closed
Assignees
Labels
🧪 engineering Related to some internal engineering improvements ✅ merged A fix for this issue has been merged
Milestone

Comments

@craxal
Copy link
Contributor

craxal commented Dec 15, 2023

Components hosted in separate processes can register for app-wide events. For example, panels can listen for configuration changes. Some of these separate processes live alongside the app's main process. Others are temporary (for example, panels). These temporary panels don't unregister listeners. Over the course of an app session, many orphaned listeners can accumulate if many panels are opened and closed.

Additional lifecycle events should be put into place so that processes know when something is about to be terminated and needs to dispose of resources properly.

@craxal craxal changed the title Investigate potential memory leaks from event registration Investigate and plug up potential memory leaks from event registration Dec 15, 2023
@MRayermannMSFT MRayermannMSFT added the 🧪 engineering Related to some internal engineering improvements label Dec 28, 2023
@MRayermannMSFT MRayermannMSFT added this to the 1.35.0 milestone Jan 22, 2024
@JasonYeMSFT JasonYeMSFT added the ✅ merged A fix for this issue has been merged label Jun 5, 2024
@JasonYeMSFT
Copy link
Contributor

Fixed a bug in WebviewTabViewModel using the memory profiler. I checked other dynamically allocated resources such as activity and tree view nodes and I don't see them leaking any memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 engineering Related to some internal engineering improvements ✅ merged A fix for this issue has been merged
Projects
None yet
Development

No branches or pull requests

3 participants