Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.0 is broken for US Government #61

Closed
smichelotti opened this issue Apr 23, 2018 · 5 comments
Closed

Version 1.0.0 is broken for US Government #61

smichelotti opened this issue Apr 23, 2018 · 5 comments
Assignees
Labels
🪲 bug Issue is not intended behavior ⚙️ sign-in Related to sign-in ✅ merged A fix for this issue has been merged
Milestone

Comments

@smichelotti
Copy link
Member

Storage Explorer Version:
1.0.0

OS Version:
Windows 10

Steps to Reproduce:

  1. Try to connect normally for any Azure US Government account

Expected Experience:
Should connect successfully. Instead it shows error that I can't get subscriptions. Here is the error from the F12 Dev tools console: Could not load subscriptions for tenant ee288926-3dba-450a-ab95-348da135500a, error: [object Object]

Actual Experience:
Unable to connect. Even if you remove the account and restart Storage Explorer. Prior to version 1.0.0, this works fine for US Government. We've verified this for multiple people/account/machines for the people on our team.

@craxal craxal added the ❔ more info More information is needed from issue author to proceed label Apr 23, 2018
@MRayermannMSFT MRayermannMSFT added 🪲 bug Issue is not intended behavior and removed ❔ more info More information is needed from issue author to proceed labels Apr 23, 2018
@MRayermannMSFT
Copy link
Member

MRayermannMSFT commented Apr 23, 2018

Hi @smichelotti . Thanks for reporting this bug. The root cause has been found and a fix will be shipped in our next update. Until then you can either:

Patching Storage Explorer to fix Azure Government

  1. Remove all Azure Government accounts
  2. Close Storage Explorer
  3. Open your favorite text editor as admin
  4. Open "C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\out\app\renderer\AzureEnvironmentsManagement\AzureEnvironmentsManager.js" (modify path to where you installed if need be, let me know if you need help on macOS as well)
  5. On line 89 (the resource endpoint for the "fairfax") object, add a slash to the end of the string:
    ![image]
    See below comment.
  6. Save, and then try to sign in with Storage Explorer

@MRayermannMSFT MRayermannMSFT added the ⚙️ sign-in Related to sign-in label Apr 23, 2018
@smichelotti
Copy link
Member Author

Thanks. I have verified the suggested patch works successfully as a short-term fix until the next update ships.

@MRayermannMSFT MRayermannMSFT added this to the 1.1.0 milestone Apr 23, 2018
@MRayermannMSFT
Copy link
Member

MRayermannMSFT commented Apr 23, 2018

Apologies, a few other values need to be updated. Please replace the fairfax object witht the below:

"fairfax": {
        AuthenticationQueryParameters: "",
        AsmEndPoint: "https://management.usgovcloudapi.net/",
        Authority: "https://login-us.microsoftonline.com/",
        AzureResourceManagementEndpoint: "https://management.usgovcloudapi.net/",
        AzureResourceManagementAudienceEndpoints: [
            "https://management.usgovcloudapi.net/"
        ],
        ClientIdentifier: this._clientId,
        EnvironmentName: "Fairfax",
        GraphEndpoint: "https://graph.windows.net",
        MsaHomeTenantId: "f577cd82-810c-43f9-a1f6-0cc532871050",
        NativeClientRedirect: "urn:ietf:wg:oauth:2.0:oob",
        PortalEndpoint: "https://portal.core.usgovcloudapi.net/",
        ResourceEndpoint: "https://management.core.usgovcloudapi.net/",
        ValidateAuthority: true,
        VisualStudioOnlineEndpoint: "https://app.vssps.visualstudio.com/",
        VisualStudioOnlineAudience: "499b84ac-1321-427f-aa17-267ca6975798"
}

@MRayermannMSFT
Copy link
Member

Another easy workaround:

  1. Open connect dialog
  2. Choose "Create Custom Environment" in the "Azure environment:" dropdown
  3. Input "US Govt" as the "Environment name:" and https://management.usgovcloudapi.net/ as the "ARM endpoint:"
  4. Click "Sign in..."

Anytime you want to add another govt account, choose "Use Custom Environment" in the "Azure environment" dropdown, and use the "US Govt" environment. Also, we'll be shipping the fix for this issue in 1.1.0.

@MRayermannMSFT
Copy link
Member

Fix has been merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Issue is not intended behavior ⚙️ sign-in Related to sign-in ✅ merged A fix for this issue has been merged
Projects
None yet
Development

No branches or pull requests

3 participants