Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The URL of the ADLS Gen2 folder shows incorrectly in the 'Properties' dialog #3357

Closed
v-limu opened this issue Aug 6, 2020 · 8 comments
Closed
Assignees
Labels
⚙️ adls gen2 Related to hierarchical namespaces (ADLS Gen 2) 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Milestone

Comments

@v-limu
Copy link

v-limu commented Aug 6, 2020

Storage Explorer Version: 1.15.0-dev
Build: 20200806.6
Branch: master
Platform/OS: Windows 10/ CentOS 7.6.1810 (Core) / MacOS Catalina
Architecture: ia32/x64
Regression From: Not a regression

Steps to reproduce:

  1. Expand one ADLS Gen2 storage account -> Blob Containers.
  2. Create a new blob container -> Create a new folder -> Click 'Properties' in the toolbar.
  3. Check the URL in the dialog.

Expect Experience:
The URL shows correctly in the 'Properties' dialog.
image
Actual Experience:
The URL shows incorrectly in the 'Properties' dialog.
image

@v-limu v-limu added 🧪 testing Found through regular testing ⚙️ adls gen2 Related to hierarchical namespaces (ADLS Gen 2) labels Aug 6, 2020
@MRayermannMSFT
Copy link
Member

MRayermannMSFT commented Aug 10, 2020

gen2 apis -> use dfs endpoint -> folders only real in gen2 apis
blob apis -> use blob endpoint -> folders not real in blob apis

So for a folder, showing dfs endpoint makes sense.

Once interop supports folder properties, we can move the impl of "show folder properties" to using the blob SDK, and this URL will change to be a blob endpoint URL.

@craxal should check with platform team if interop supports folder properties yet. If it does, he can move the impl. If it doesn't, but will eventually, issue should be retriaged to whenever support is anticipated. If it never will, he can close this.

@MRayermannMSFT MRayermannMSFT added this to the 1.17.0 milestone Aug 10, 2020
@MRayermannMSFT
Copy link
Member

Related to #3056

@craxal
Copy link
Contributor

craxal commented Nov 19, 2020

Communicating with the client library team to understand the expected behavior of @azure/storage-blob and @azure/storage-file-datalake. We currently use @azure/storage-blob to list blobs for both standard and ADLS Gen2 blob containers. It does return last modified properties for blob items, but not for blob prefixes (folders).

@craxal
Copy link
Contributor

craxal commented Dec 4, 2020

According to the client library team, the blobs library does support folder properties; folders are grouped with other blobs and have a special property.

@craxal craxal modified the milestones: 1.17.0, 1.18.0 Dec 4, 2020
@MRayermannMSFT
Copy link
Member

Am going to move manage properties for gen2 paths to blob ext. And for gen2, we will show both blob and dfs paths.

@MRayermannMSFT
Copy link
Member

All gen2 property dialogs show now include a DFS and a Blob url.

@MRayermannMSFT MRayermannMSFT added the ✅ merged A fix for this issue has been merged label Feb 12, 2021
@v-xianya
Copy link
Member

Hi @MRayermannMSFT thanks for the update! Now there are both DFS & Blob URL properties for one ADLS Gen2 file.
What would be the exact URL when using the action 'Copy URL'?

@MRayermannMSFT
Copy link
Member

MRayermannMSFT commented Feb 19, 2021

It should be the blob URL, both for gen2 and non-gen2 blobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ adls gen2 Related to hierarchical namespaces (ADLS Gen 2) 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Projects
None yet
Development

No branches or pull requests

4 participants