Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy TelemetryConfiguration.Active from AspNetCore SDK #1953

Closed
TimothyMothra opened this issue Jul 6, 2020 · 0 comments
Closed
Milestone

Comments

@TimothyMothra
Copy link
Member

TimothyMothra commented Jul 6, 2020

Currently, AspNetCore depends on TelemetryConfiguration.Active and would copy all configured options to this singleton.
Once this dependency is removed we will no longer have a need for this singleton.

(For further reading.. this dependency is due to the Heartbeat feature #1954).

For backwards compatibility, we will introduce a new setting: ApplicationInsightsServiceOptions.EnableActiveTelemetryConfigurationSetup.
This will once again copy the TelemetryConfiguration configured via DI to the TelemetryConfiguration.Active singleton.

@TimothyMothra TimothyMothra added this to the 2.15 milestone Jul 6, 2020
@TimothyMothra TimothyMothra changed the title remove legacy TelemetryConfiguration.Active from AspNetCore SDK. remove legacy TelemetryConfiguration.Active from AspNetCore SDK and refactor Heartbeat Jul 6, 2020
@TimothyMothra TimothyMothra changed the title remove legacy TelemetryConfiguration.Active from AspNetCore SDK and refactor Heartbeat remove legacy TelemetryConfiguration.Active from AspNetCore SDK Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant