Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric Aggregator uses dedicated thread and hence should catch all exceptions #1179

Closed
cijothomas opened this issue Jul 24, 2019 · 0 comments
Assignees
Milestone

Comments

@cijothomas
Copy link
Contributor

cijothomas commented Jul 24, 2019

MetricAggregator is the only place in this SDK which creates a new Thread for running background task. The code should be protected from ever throwing unhandled exception as it could crash the application. While no existing occurences are reported, this should be done to avoid issues like microsoft/ApplicationInsights-dotnet-server#1088

this.aggregationThread = new Thread(this.Run);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant