Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should use X-Forwarded-For as Client IP when present #404

Closed
klazuka opened this issue Aug 4, 2017 · 2 comments
Closed

Should use X-Forwarded-For as Client IP when present #404

klazuka opened this issue Aug 4, 2017 · 2 comments
Milestone

Comments

@klazuka
Copy link

klazuka commented Aug 4, 2017

Many load balancers / proxies automatically set the X-Forwarded-For HTTP request header to indicate the original IP of the client. The Application Insights SDK for .NET uses this header when present to fill in the client IP, but the Java SDK does not. For more details, see http://apmtips.com/blog/2016/07/05/client-ip-address/

The fix would be to copy what the .NET SDK does: handle X-Forwarded-For automatically by default, while still allowing the ability to specify an alternative HTTP header name for the IP.

@littleaj
Copy link
Contributor

@trask @AlexKlimovMS seems reasonable and still relevant

@trask trask added this to the future milestone Jun 10, 2020
@trask trask modified the milestones: future, 3.0.0 Sep 13, 2020
@trask
Copy link
Member

trask commented Sep 25, 2020

This is fixed now in Preview.7

@trask trask closed this as completed Sep 25, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants