Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertx HTTP Library Instrumentation Support #1651

Closed
zoomingrocket opened this issue Apr 23, 2021 · 3 comments · Fixed by #1990
Closed

Vertx HTTP Library Instrumentation Support #1651

zoomingrocket opened this issue Apr 23, 2021 · 3 comments · Fixed by #1990

Comments

@zoomingrocket
Copy link

zoomingrocket commented Apr 23, 2021

Is your feature request related to a problem? Please describe.
Enable Vertx HTTP Library Instrumentation Support

Describe the solution you would like
Allow Requests & dependency tracing for HTTP requests served by Vertx library

Describe alternatives you have considered
None

Additional context
Current Java Agent Version used: v3.0.3 GA
https://vertx.io/docs/vertx-web-client/java/

@zoomingrocket zoomingrocket changed the title Vertx HTTP Request & Dependency Tracing Support Vertx HTTP Library Instrumentation Support Apr 23, 2021
@trask trask added this to the future milestone Jul 23, 2021
@ghost ghost added the Status: Fixed label Jan 13, 2022
@trask
Copy link
Member

trask commented Jan 19, 2022

this is included in 3.2.5-BETA, it's not documented yet at https://docs.microsoft.com/en-us/azure/azure-monitor/app/java-standalone-config#preview-instrumentations, but the json key to use is "vertx"

@zoomingrocket
Copy link
Author

@trask - json key "vertx" is not recognized. Startup Info with 3.2.5 BETA

2022-01-22 00:08:18.347Z WARN  c.m.a.a.i.c.ConfigurationBuilder - Unrecognized field "vertx" (class com.microsoft.applicationinsights.agent.internal.configuration.Configuration$PreviewInstrumentation), not marked as ignorable (10 known properties: "akka", "play", "javaHttpClient", "springIntegration", "apacheCamel", "azureSdk", "jaxws", "rabbitmq", "grizzly", "quartz"])
 at [Source: (sun.nio.ch.ChannelInputStream); line: 276, column: 17] (through reference chain: com.microsoft.applicationinsights.agent.internal.configuration.Configuration["preview"]->com.microsoft.applicationinsights.agent.internal.configuration.Configuration$PreviewConfiguration["instrumentation"]->com.microsoft.applicationinsights.agent.internal.configuration.Configuration$PreviewInstrumentation["vertx"])
2022-01-22 00:08:20.986Z INFO  c.m.applicationinsights.agent - ApplicationInsights Java Agent 3.2.5-BETA started successfully (PID 16170)

JSON Config

"preview": {
    "exportQueueCapacity": 4096,
    "instrumentation": {
      "vertx": {
        "enabled": true
      }
    }
}

@trask
Copy link
Member

trask commented Jan 22, 2022

hey @zoomingrocket, ya, sorry about that, I didn't realize, it's actually on by default in 3.2.5-BETA, though we're considering changing that behavior before 3.2.5 GA: #2058

@ghost ghost locked as resolved and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants