-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distance sensor Upgrades #2807
Distance sensor Upgrades #2807
Conversation
a0b70fa
to
cbceb09
Compare
/azp run microsoft.AirSim |
Azure Pipelines successfully started running 1 pipeline(s). |
1ce5b73
to
522a293
Compare
How does the distance sensor airsim measure the distance from the car to the obstacles in front? because from the simulation that has been done, the result of the distance always increases even though the distance from the car to the obstacle is getting closer |
@mirarmdn Distance sensor uses a ray cast to measure the distance. You're right, I just tested, and there's some problem with Car vehicle, the distance values don't make sense. It's working correctly on Multirotor vehicle though. Need to look into this |
@rajat2004 What should I do? I desperately need the distance sensors to measure the distance from the car to the obstacle. I've looked into several sources, but I haven't found an answer. Can you help me |
Plus fix for Car sensor default pose
Distances are float, not Quaternion
51d3cb8
to
c7c080c
Compare
@mirarmdn I've pushed the fix for the Car vehicle, the problem was that the sensor was inside the vehicle, and so gave the wrong values. Moving it by 1 meter above fixes the problem, this is also being done in Lidar as well. Added an example script as well for measuring the distance between 2 vehicles which I used for testing |
This PR is looking good and complete to me. @rajat2004 do you want to add anything else here? |
@madratman Don't think so, I was thinking of adding support for distance sensor in ArduCopter, Rover vehicles but that will take time and requires a PR in AP repository to be merged first, so this can go in and will open a new PR later when that happens. |
Yes, let's add those features in next PR. I'm getting this in. |
Problem: Distance sensor data: Car1: 0.0, Car2: 0.0 |
@fracnaive Your sensor is probably below the vehicle, in the ground itself. NED is used here, so +ve Z will be downwards. |
I get it,thanks! |
DistanceSensorData
struct intypes.py
(Should be float, not Quaternion)Default sensor-
Downward-facing (altitude measurement)-
2 Cars with distance sensor
Closes #2723, closes #2806
Related issues - #2444, #1029
Question: Should there be fields in settings for other params such as
update_frequency
, noise, etc? Currently haven't added those