Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features: add an api for setting trace line color and thickness #2506

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

songxiaocheng
Copy link
Contributor

There is a little problem that the alpha channel is not working. I also tried to manually call DrawDebugLine but the trace lines are always opaque. It seems like a UE issue, so I kept this argument. For now, setting RGB and thickness works well.

@madratman
Copy link
Contributor

madratman commented Apr 1, 2020

Can we maintain consistency w.r.t. simPlot APIs (those APIs ask for rgba list in python in 0-1 range) (see plot_markers.py)

the lines here might make alpha channel work
https://github.com/microsoft/AirSim/pull/2304/files#diff-405ee0a8e5b40c6316073f72165e0228R177
https://github.com/microsoft/AirSim/pull/2304/files#diff-405ee0a8e5b40c6316073f72165e0228R180

@songxiaocheng
Copy link
Contributor Author

Hi @madratman, I've updated as you suggested.
As for the alpha channel problem, the two lines code you mentioned is not working either.
Actually, in my test, the alpha channel is also failed to work for the simPlot* APIs. Do you have the same problem?

@madratman
Copy link
Contributor

Unable to resolved the transparency, but apart from that, it works fine.
Thanks for the contribution!

@madratman madratman merged commit a8a2515 into microsoft:master Apr 14, 2020
@songxiaocheng songxiaocheng deleted the PR/set_traceline branch April 19, 2020 06:47
@rajat2004
Copy link
Contributor

rajat2004 commented Apr 21, 2020

What is the range of thickness here? 0-100? and is it in pixels
Working on adding docstrings for all the APIs, so need to add this info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants