From 6cf979521451886e61954e6171610213b780c835 Mon Sep 17 00:00:00 2001 From: David Claux Date: Mon, 20 Jul 2020 11:38:47 -0700 Subject: [PATCH] Emit warning for required inputs without label --- source/nodejs/adaptivecards/src/card-elements.ts | 7 +++++++ source/nodejs/adaptivecards/src/enums.ts | 1 + 2 files changed, 8 insertions(+) diff --git a/source/nodejs/adaptivecards/src/card-elements.ts b/source/nodejs/adaptivecards/src/card-elements.ts index ad4ad5e436..bbeb1ddb2a 100644 --- a/source/nodejs/adaptivecards/src/card-elements.ts +++ b/source/nodejs/adaptivecards/src/card-elements.ts @@ -2570,6 +2570,13 @@ export abstract class Input extends CardElement implements IInput { Enums.ValidationEvent.PropertyCantBeNull, "All inputs must have a unique Id"); } + + if (this.isRequired && !this.label) { + context.addFailure( + this, + Enums.ValidationEvent.RequiredInputsShouldHaveLabel, + "Required inputs should have a label"); + } } validateValue(): boolean { diff --git a/source/nodejs/adaptivecards/src/enums.ts b/source/nodejs/adaptivecards/src/enums.ts index 513449edee..51ec1c7448 100644 --- a/source/nodejs/adaptivecards/src/enums.ts +++ b/source/nodejs/adaptivecards/src/enums.ts @@ -169,6 +169,7 @@ export enum ValidationEvent { UnsupportedCardVersion, DuplicateId, UnsupportedProperty, + RequiredInputsShouldHaveLabel, Other }