Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URI creation from path #3467

Closed
aeschli opened this issue Aug 27, 2018 · 0 comments
Closed

Fix URI creation from path #3467

aeschli opened this issue Aug 27, 2018 · 0 comments
Labels
bug Product bug ships-in-future-update The issue is fixed in our 'master' branch and will ship in the next PREVIEW release
Milestone

Comments

@aeschli
Copy link

aeschli commented Aug 27, 2018

In 1.26 we discovered that several extensions call the 'vscode.openFolder' command with invalid file URIs:

ms-dynamics-smb.al/out/src/services/bootstrapService.js
  57,45:             vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(dir));

When creating a URI from a file path, always use vscode.URI.file(path), e.g vscode.URI.file('c:\\test')
Use vscode.URI.parse(uriString) when the input string is in the form scheme://authority/path

See microsoft/vscode#57267 for more information or for questions.

  • AL Extension Version:
  • Server Version:
@thpeder thpeder added bug Product bug ships-in-future-update The issue is fixed in our 'master' branch and will ship in the next PREVIEW release labels Aug 28, 2018
@thpeder thpeder added this to the August 2018 milestone Aug 28, 2018
@microsoft microsoft locked and limited conversation to collaborators Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Product bug ships-in-future-update The issue is fixed in our 'master' branch and will ship in the next PREVIEW release
Projects
None yet
Development

No branches or pull requests

3 participants