Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 'logo' in Metadata interface when using metascraper-logo plugin #657

Closed
2 tasks done
quentingrchr opened this issue Aug 18, 2023 · 1 comment · Fixed by #673
Closed
2 tasks done

Missing 'logo' in Metadata interface when using metascraper-logo plugin #657

quentingrchr opened this issue Aug 18, 2023 · 1 comment · Fixed by #673

Comments

@quentingrchr
Copy link

quentingrchr commented Aug 18, 2023

Prerequisites

  • I'm using the last version.
  • My node version is the same as declared as package.json.

The 'logo' property in Metadata interface is missing when using metascraper-logo plugin

When I use metascraper with Typescript with those plugins :

  • metascraper-logo
  • metascraper-logo-favicon
  • metascraper-image
  • metascraper-description
  • metascraper-title

The Metadata interface doesn't include the new properties added by the metascraper-logo and metascraper-logo-favicon plugins

Steps to reproduce

Go to the reproduction link
Line 43 the logo property doesn't exist

Expected behaviour

Metadata Interface should reflect all the property added by the plugins (in this example 'logo')

Actual behaviour

Metadata doesn't have the property added by the metascraper-logo and metascraper-logo-favicon plugins

@Kikobeats
Copy link
Member

Can you make a PR? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants