fix: get tweet image when it's a tweet (#617)

microlinkhq · Jan 27, 2023 · f3540a6 · f3540a6
1 parent 7748d97
commit f3540a6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/packages/metascraper-twitter/index.js b/packages/metascraper-twitter/index.js
@@ -47,8 +47,12 @@ module.exports = () => {
       })
     ],
     image: [
-      toImage($ => avatarUrl($jsonld('author.image.contentUrl')($))),
+      toImage(
+        ($, url) =>
+          isTweet(url) && $('meta[property="og:image"]').attr('content')
+      ),
       toImage(($, url) => isTweet(url) && $('video').attr('poster')),
+      toImage($ => avatarUrl($jsonld('author.image.contentUrl')($))),
       toImage($ => avatarUrl($('article img[src]').attr('src')))
     ],
     video: [toVideo(($, url) => isTweet(url) && $('video').attr('src'))],

diff --git a/packages/metascraper-twitter/test/snapshots/index.js.md b/packages/metascraper-twitter/test/snapshots/index.js.md
@@ -67,7 +67,7 @@ Generated by [AVA](https://avajs.dev).
       author: '#!/kiko/beats',
       date: '2017-06-28T19:01:34.000Z',
       description: '“Experimenting with Clearbit API + Apple TV 3D Parallax https://t.co/Qsm163k4mJ”',
-      image: 'https://pbs.twimg.com/tweet_video_thumb/DDbh3WCXYAAZfz9.jpg',
+      image: 'https://pbs.twimg.com/tweet_video_thumb/DDbh3WCXYAAZfz9.jpg:large',
       lang: 'en',
       publisher: 'Twitter',
       title: '@Kikobeats on Twitter',
@@ -83,7 +83,7 @@ Generated by [AVA](https://avajs.dev).
       author: 'Brad, what are you gonna do?',
       date: '2017-11-25T18:04:12.000Z',
       description: '“Lo mejor de @codemotion_es #codemotionMadrid es estar con la gente que quieres 😍@ladyCircus”',
-      image: 'https://pbs.twimg.com/profile_images/1603675274348040192/y9P6VlyX_400x400.jpg',
+      image: 'https://pbs.twimg.com/media/DPfzNMGXUAESoL3.jpg:large',
       lang: 'en',
       publisher: 'Twitter',
       title: '@k4rliky on Twitter',

diff --git a/packages/metascraper-twitter/test/snapshots/index.js.snap b/packages/metascraper-twitter/test/snapshots/index.js.snap