Improve logo detection

microlinkhq · Sep 18, 2017 · 3040379 · 3040379
1 parent 108e79c
commit 3040379
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/__snapshots__/index.js.snap-shot b/__snapshots__/index.js.snap-shot
@@ -196,7 +196,7 @@ exports['et-tech 1'] = {
   "description": "Dell speaks about the complexities of engineering the biggest acquisition in tech history, Dell’s future bets and why he continues to remain bullish..",
   "favicon": "http://b2bstatic.iimg.in/Themes/Release/images/tech-favicon.ico",
   "image": "http://economictimes.indiatimes.com/photo/michael-dell-on-complexities-involved-in-pulling-off-the-biggest-tech-acquisition-dell-s-future-bets-more/52424992.cms",
-  "logo": "http://b2bstatic.iimg.in/Themes/Release/images/responsive/tech-logo-footer.png",
+  "logo": "http://b2bstatic.iimg.in/Themes/Release/images/responsive/tech-logo-square.jpg",
   "publisher": "ETtech.com",
   "title": "Michael Dell on complexities involved in pulling off the biggest tech acquisition, Dell’s future bets & more | ETtech",
   "url": "http://tech.economictimes.indiatimes.com/news/corporate/michael-dell-biggest-tech-acquisition-future-bets/52424992"

diff --git a/src/get-data/rules/logo.js b/src/get-data/rules/logo.js
@@ -23,6 +23,7 @@ const wrap = rule => (htmlDom, baseUrl) => {
 module.exports = [
   wrap($ => $('meta[property="og:logo"]').attr('content')),
   wrap($ => $('meta[itemprop="logo"]').attr('content')),
+  wrap($ => $('img[itemprop="logo"]').attr('src')),
   wrap($ => $('img[src*="logo"]').attr('src')),
   wrap($ => $('img[class*="logo"]').attr('src'))
 ]
diff --git a/test/mocha.opts b/test/mocha.opts
@@ -2,5 +2,4 @@
 --reporter list
 --timeout 120000
 --slow 300
---bail
 --recursive